You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2017/09/08 12:15:51 UTC
[GitHub] brooklyn-docs pull request #209: [WIP] explain and use the `brooklyn-demo-sa...
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-docs/pull/209
[WIP] explain and use the `brooklyn-demo-sample` external provider
so far just explains it, need to use it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-docs external-config-in-example
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-docs/pull/209.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #209
----
commit 8138884cf3c32ba988f76c8008e5c9ee671360b5
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2017-09-08T12:12:55Z
explain the `brooklyn-demo-sample` external provider
----
---
[GitHub] brooklyn-docs issue #209: explain and use the `brooklyn-demo-sample` externa...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-docs/pull/209
examples all updated, ready to merge after https://github.com/apache/brooklyn-server/pull/812
---
[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/209#discussion_r138858493
--- Diff: guide/blueprints/multiple-services.md ---
@@ -41,8 +41,11 @@ Here there are a few things going on:
* We've added a second service, which will be the database;
you'll note the database has been configured to run a custom setup script
* We've injected the URL of the second service into the appserver as a Java system property
- (so our app knows where to find the database)
-
+ (so our app knows where to find the database)
+* We've used externalized config to keep secret information out of the blueprint;
+ this is loaded at runtime from an [externalized config provider](../ops/externalized-config.html),
+ such as a remote credentials store
--- End diff --
Missing full stop.
---
[GitHub] brooklyn-docs issue #209: explain and use the `brooklyn-demo-sample` externa...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-docs/pull/209
@drigodwin @aledsage merged the upstream PRs -- is this good to go?
(and if you could have a quick look at #208 i'd be obliged!)
---
[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/209#discussion_r138858735
--- Diff: guide/ops/cli/cli-usage-guide.md ---
@@ -439,7 +439,7 @@ tvZoNUTN ssh: launching NginxControllerImpl{id... Sun Dec 20 19:18:08 GMT 20
{% endhighlight %}
## YAML Blueprint
-This the YAML blueprint used for this document.
+This the YAML blueprint used for this document, based on the [web cluster](../../blueprints/clusters-and-policies.html) examples.
--- End diff --
This the -> This is the
---
[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/209#discussion_r141077472
--- Diff: guide/ops/externalized-configuration.md ---
@@ -64,6 +68,18 @@ brooklyn.external.credentials.appId=MyApp
In this case, the list of servers is stored in a properties file located on an Operations Department web server, and the
credentials are stored in an instance of [Vault](https://www.vaultproject.io/).
+More information on these providers is below.
+
+For demo purposes, there is a pre-defined external provider called
+`brooklyn-demo-sample` which defines `hidden-brooklyn-password` as `br00k11n`.
+This is used in some of the sample blueprints, referencing `$brooklyn:external("brooklyn-demo-sample", "hidden-brooklyn-password")`.
+The value used here can be overridden with the following in your `brooklyn.properties`:
--- End diff --
They have been changed in #210 already. I'll merge this though and make a new PR.
---
[GitHub] brooklyn-docs issue #209: explain and use the `brooklyn-demo-sample` externa...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-docs/pull/209
updated. suggest this be backported to 0.12.0 in addition to master.
---
[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/209#discussion_r138858936
--- Diff: guide/ops/externalized-configuration.md ---
@@ -64,6 +68,18 @@ brooklyn.external.credentials.appId=MyApp
In this case, the list of servers is stored in a properties file located on an Operations Department web server, and the
credentials are stored in an instance of [Vault](https://www.vaultproject.io/).
+More information on these providers is below.
+
+For demo purposes, there is a pre-defined external provider called
+`brooklyn-demo-sample` which defines `hidden-brooklyn-password` as `br00k11n`.
+This is used in some of the sample blueprints, referencing `$brooklyn:external("brooklyn-demo-sample", "hidden-brooklyn-password")`.
+The value used here can be overridden with the following in your `brooklyn.properties`:
--- End diff --
`brooklyn.cfg` as the next release will be karaf?
---
[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/209#discussion_r141041198
--- Diff: guide/blueprints/multiple-services.md ---
@@ -41,8 +41,11 @@ Here there are a few things going on:
* We've added a second service, which will be the database;
you'll note the database has been configured to run a custom setup script
* We've injected the URL of the second service into the appserver as a Java system property
- (so our app knows where to find the database)
-
+ (so our app knows where to find the database)
+* We've used externalized config to keep secret information out of the blueprint;
+ this is loaded at runtime from an [externalized config provider](../ops/externalized-config.html),
+ such as a remote credentials store
--- End diff --
style issue - omitting full stops on single-sentence bullet points is common, don't feel strongly but should ideally be conisstent w two bullet poitns above (and elsewhere), which it is
---
[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/209#discussion_r141041459
--- Diff: guide/ops/externalized-configuration.md ---
@@ -64,6 +68,18 @@ brooklyn.external.credentials.appId=MyApp
In this case, the list of servers is stored in a properties file located on an Operations Department web server, and the
credentials are stored in an instance of [Vault](https://www.vaultproject.io/).
+More information on these providers is below.
+
+For demo purposes, there is a pre-defined external provider called
+`brooklyn-demo-sample` which defines `hidden-brooklyn-password` as `br00k11n`.
+This is used in some of the sample blueprints, referencing `$brooklyn:external("brooklyn-demo-sample", "hidden-brooklyn-password")`.
+The value used here can be overridden with the following in your `brooklyn.properties`:
--- End diff --
that will need to be changed in lots of places, including the first para of this doc. changing just here is weird. suggest it be a different tranch of work.
---
[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/209
---