[jira] [Commented] (CAMEL-10874) JettyHttpComponent sets selector threads to 0 when running on 1 CPU

["Claus Ibsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877714#comment-15877714 ] 

Claus Ibsen commented on CAMEL-10874:
-------------------------------------

Thanks Nick, I wonder if you want to try to provide a fix as a github PR
http://camel.apache.org/contributing

https://github.com/apache/camel/

> JettyHttpComponent sets selector threads to 0 when running on 1 CPU
> -------------------------------------------------------------------
>
>                 Key: CAMEL-10874
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10874
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-jetty
>    Affects Versions: 2.16.5, 2.17.5, 2.18.2
>            Reporter: Nick Houghton
>            Assignee: Andrea Cosentino
>
> In JettyHttpComponent, "createHttpClientTransport" method the number of selectors is derived by:
> {noformat}
> int selectors = Runtime.getRuntime().availableProcessors() / 2;
> {noformat}
> If the number of available processors is 1, divided by 2, cast to int is 0 which causes an IllegalArgumentException.
> The safe way to do this is via Math.max, like the Jetty code does:
> {noformat}
> int selector = Math.max(1, Runtime.getRuntime().availableProcessors() / 2);
> {noformat}
> As per the code this is only exercised when maxThreads is not null, otherwise the default constructor is called and selectors are created properly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)