You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/05 12:05:55 UTC
[GitHub] [flink] xintongsong commented on a change in pull request #8303:
[FLINK-12343]add file replication config for yarn configuration
xintongsong commented on a change in pull request #8303: [FLINK-12343]add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r300625898
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -747,6 +747,17 @@ public ApplicationReport startAppMaster(
// ship list that enables reuse of resources for task manager containers
StringBuilder envShipFileList = new StringBuilder();
+ int fileReplication = yarnConfiguration.getInt("dfs.replication", 3);
+ final String replication = flinkConfiguration.getString(YarnConfigOptions.FILE_REPLICATION);
+ if (!StringUtils.isNullOrWhitespaceOnly(replication)) {
Review comment:
I would suggest making `FILE_REPLICATION` an integer type option, and check whether user has set this config with `flinkConfiguration.contains(YarnConfigOption.FILE_REPLICATION)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services