[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18370: Properly fix dagrun update state endpoint

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #18370:
URL: https://github.com/apache/airflow/pull/18370#discussion_r712785616



##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -21,6 +21,10 @@
 from sqlalchemy import or_
 
 from airflow._vendor.connexion import NoContent
+from airflow.api.common.experimental.mark_tasks import (
+    set_dag_run_state_to_failed,
+    set_dag_run_state_to_success,
+)

Review comment:
       Hi Kaxil, I think the utility functions inside` common/experimental` package are not yet deprecated but the experimental REST API is? The experimental API lives in `api/client` package.  I tried not using these functions but the change was big. Now I'm suggesting we use it but move the useful util functions out of the `/experimental` or rename the `/experimental` to api_utils or something appropriate?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org