You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "dhavaljrajpara (via GitHub)" <gi...@apache.org> on 2025/12/30 09:51:29 UTC
[PR] RANGER-5332 : Ranger: Upgrade axios version 1.8.4 to latest 1.12.2 [ranger]
dhavaljrajpara opened a new pull request, #776:
URL: https://github.com/apache/ranger/pull/776
## What changes were proposed in this pull request?
Upgrade axios version 1.8.4 to latest 1.12.2
## How was this patch tested?
1. Applied the patch locally.
2. Verified that the build completed successfully.
3. Checked that the development server started and worked properly.
4. Performed UI-level sanity testing on the following modules and pages. I verified that all input values are trimmed of whitespace before being sent to the server.
- Service
- Policy
- User, Group, Role
- Security Zone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5332 : Ranger: Upgrade axios version 1.8.4 to latest 1.12.2 [ranger]
Posted by "vyommani (via GitHub)" <gi...@apache.org>.
vyommani commented on code in PR #776:
URL: https://github.com/apache/ranger/pull/776#discussion_r2654762889
##########
security-admin/src/main/webapp/react-webapp/src/App.jsx:
##########
@@ -21,7 +21,12 @@ import React, { Suspense, lazy, Component } from "react";
import { Route, Routes, HashRouter } from "react-router-dom";
import { ToastContainer } from "react-toastify";
import axios from "axios";
-import { hasAccessToTab, isUser } from "Utils/XAUtils";
+import {
Review Comment:
This Jira ticket is intended for upgrading Axios from version 1.8.4 to the latest version 1.12.2. However, while reviewing the changes, I noticed several additional modifications beyond the version upgrade, including new if conditions that appear to alter the original logic. Since I'm not fully aware of the context or intent behind these extra changes, could you please explain the purpose and rationale for these modifications (apart from the Axios version upgrade itself)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5332 : Ranger: Upgrade axios version 1.8.4 to latest 1.12.2 [ranger]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj merged PR #776:
URL: https://github.com/apache/ranger/pull/776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org