You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/16 13:39:34 UTC
[GitHub] [spark] panbingkun opened a new pull request, #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
panbingkun opened a new pull request, #38274:
URL: https://github.com/apache/spark/pull/38274
### What changes were proposed in this pull request?
This pr aims to use Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand.
### Why are the changes needed?
Better error reporting.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existed UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r1005162901
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -709,6 +709,11 @@
}
}
},
+ "UNSUPPORTED_EMPTY_LOCATION" : {
+ "message" : [
+ "Unsupported empty location."
Review Comment:
empty location is a bit misleading. This is not a location with no files/directories, it's empty string. How about
```
EMPTY_STRING_AS_LOCATION: Can not reference a location with an empty string.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38274:
URL: https://github.com/apache/spark/pull/38274#issuecomment-1283453081
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r1005251579
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -709,6 +709,11 @@
}
}
},
+ "UNSUPPORTED_EMPTY_LOCATION" : {
+ "message" : [
+ "Unsupported empty location."
Review Comment:
@panbingkun Could you open a follow up PR and change this, and address below comment, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r998144484
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4207,5 +4207,10 @@
"message" : [
"Not enough memory to build and broadcast the table to all worker nodes. As a workaround, you can either disable broadcast by setting <autoBroadcastjoinThreshold> to -1 or increase the spark driver memory by setting <driverMemory> to a higher value<analyzeTblMsg>"
]
+ },
+ "_LEGACY_ERROR_TEMP_2251" : {
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r1005163283
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterNamespaceSetLocationSuiteBase.scala:
##########
@@ -45,10 +46,13 @@ trait AlterNamespaceSetLocationSuiteBase extends QueryTest with DDLCommandTestUt
val ns = s"$catalog.$namespace"
withNamespace(ns) {
sql(s"CREATE NAMESPACE $ns")
- val message = intercept[IllegalArgumentException] {
- sql(s"ALTER NAMESPACE $ns SET LOCATION ''")
- }.getMessage
- assert(message.contains("Can not create a Path from an empty string"))
+ val sqlText = s"ALTER NAMESPACE $ns SET LOCATION ''"
Review Comment:
I think we can move this test to the base suite now, as the behavior is consistent between v1 and v2 tables.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateNamespaceSuiteBase.scala:
##########
@@ -67,15 +68,15 @@ trait CreateNamespaceSuiteBase extends QueryTest with DDLCommandTestUtils {
// The generated temp path is not qualified.
val path = tmpDir.getCanonicalPath
assert(!path.startsWith("file:/"))
-
- val e = intercept[IllegalArgumentException] {
- sql(s"CREATE NAMESPACE $ns LOCATION ''")
- }
- assert(e.getMessage.contains("Can not create a Path from an empty string"))
-
+ val sqlText = s"CREATE NAMESPACE $ns LOCATION ''"
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r996657816
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateNamespaceSuiteBase.scala:
##########
@@ -68,10 +69,10 @@ trait CreateNamespaceSuiteBase extends QueryTest with DDLCommandTestUtils {
val path = tmpDir.getCanonicalPath
assert(!path.startsWith("file:/"))
- val e = intercept[IllegalArgumentException] {
+ val e = intercept[SparkIllegalArgumentException] {
sql(s"CREATE NAMESPACE $ns LOCATION ''")
}
- assert(e.getMessage.contains("Can not create a Path from an empty string"))
+ assert(e.getMessage.contains("Unsupported empty location"))
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r998010502
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4207,5 +4207,10 @@
"message" : [
"Not enough memory to build and broadcast the table to all worker nodes. As a workaround, you can either disable broadcast by setting <autoBroadcastjoinThreshold> to -1 or increase the spark driver memory by setting <driverMemory> to a higher value<analyzeTblMsg>"
]
+ },
+ "_LEGACY_ERROR_TEMP_2251" : {
Review Comment:
Could you assign a name to the error class like: `UNSUPPORTED_EMPTY_LOCATION`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r998144484
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4207,5 +4207,10 @@
"message" : [
"Not enough memory to build and broadcast the table to all worker nodes. As a workaround, you can either disable broadcast by setting <autoBroadcastjoinThreshold> to -1 or increase the spark driver memory by setting <driverMemory> to a higher value<analyzeTblMsg>"
]
+ },
+ "_LEGACY_ERROR_TEMP_2251" : {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
URL: https://github.com/apache/spark/pull/38274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #38274:
URL: https://github.com/apache/spark/pull/38274#issuecomment-1280322307
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r996639970
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateNamespaceSuiteBase.scala:
##########
@@ -68,10 +69,10 @@ trait CreateNamespaceSuiteBase extends QueryTest with DDLCommandTestUtils {
val path = tmpDir.getCanonicalPath
assert(!path.startsWith("file:/"))
- val e = intercept[IllegalArgumentException] {
+ val e = intercept[SparkIllegalArgumentException] {
sql(s"CREATE NAMESPACE $ns LOCATION ''")
}
- assert(e.getMessage.contains("Can not create a Path from an empty string"))
+ assert(e.getMessage.contains("Unsupported empty location"))
Review Comment:
As you are here, could you use `checkError()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r996657816
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateNamespaceSuiteBase.scala:
##########
@@ -68,10 +69,10 @@ trait CreateNamespaceSuiteBase extends QueryTest with DDLCommandTestUtils {
val path = tmpDir.getCanonicalPath
assert(!path.startsWith("file:/"))
- val e = intercept[IllegalArgumentException] {
+ val e = intercept[SparkIllegalArgumentException] {
sql(s"CREATE NAMESPACE $ns LOCATION ''")
}
- assert(e.getMessage.contains("Can not create a Path from an empty string"))
+ assert(e.getMessage.contains("Unsupported empty location"))
Review Comment:
ok, let me do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38274:
URL: https://github.com/apache/spark/pull/38274#issuecomment-1280478137
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org