[GitHub] [spark] wangyum commented on a change in pull request #23500: [SPARK-24638][FOLLOW-UP][SQL] StringStartsWith UDP shall handle null values

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #23500: [SPARK-24638][FOLLOW-UP][SQL] StringStartsWith UDP shall handle null values
URL: https://github.com/apache/spark/pull/23500#discussion_r263986058
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ##########
 @@ -570,7 +570,7 @@ private[parquet] class ParquetFilters(
               }
 
               override def keep(value: Binary): Boolean = {
-                UTF8String.fromBytes(value.getBytes).startsWith(
+                value == null || UTF8String.fromBytes(value.getBytes).startsWith(
 
 Review comment:
    @dongjoon-hyun @HyukjinKwon 
   It seem does not affect Spark end-to-end work currently. 
   It seem difficult to add a test case in the current Parquet version(parquet 1.10.x).
   So are we merging this PR or closing it and fixing it in the future?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org