You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2013/03/15 22:01:14 UTC
[Android] Moving plugins to core namespace
Hey
Since we're working towards making the core plugins installable and
uninstallable, I want to go ahead and move all the plugins to a core
directory so that their Java namespace will be
org.apache.cordova.core. This means that adding and removing will be
less painful for scripts since they shouldn't be messing with anything
that's not a plugin or it's dependency.
Any thoughts on this before I move things? This shouldn't change the
API at all, and things should continue to work.
Joe
Re: [Android] Moving plugins to core namespace
Posted by Filip Maj <fi...@adobe.com>.
Yeah, I mean, I think you can keep whatever namespace we use CURRENTLY,
until that becomes a real issue / we actually split it out. Since this is
all just an exercise to see how far our plugin spec and the tooling can
go, and what's missing, the specific answer to the namespace question
isn't super important.
On 3/15/13 3:02 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>It sounds to me like the consensus is to leave them where they are for
>now. I'll keep my changes out of master for the time being.
>
>On Fri, Mar 15, 2013 at 2:56 PM, Anis KADRI <an...@gmail.com> wrote:
>> So to answer your question it is an automatic process taken care of by
>> plugman on installation/uninstallation.
>>
>>
>> On Fri, Mar 15, 2013 at 2:48 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>>> On Fri, Mar 15, 2013 at 2:41 PM, Anis KADRI <an...@gmail.com>
>>>wrote:
>>> > What is it that needs to change in the config.xml as far as plugins
>>>are
>>> > concerned ? I am hoping they will keep the same name and namespace
>>>when
>>> > they get updated, right ?
>>>
>>> That's if they get updated. When they get installed, the entry has to
>>> be added to the config.xml. Or is that still a manual process?
>>>
>>> > The only things that should change when plugins
>>> > get updated is the native/javascript code and maybe dependencies (but
>>> > that's another topic).
>>> >
>>> > As far as naming everything core, I say why not. I wonder if it's not
>>> > preferable to have one directory per plugin instead to make the
>>> separation
>>> > even more obvious:
>>> >
>>> > org.apache.cordova.acceleration.Acceleration
>>> > org.apache.cordova.capture.Capture
>>> > org.apache.cordova.file.File
>>> > org.apache.cordova.file.FileTransfer
>>> > org.apache.cordova.file.FileProgressResult
>>> >
>>>
>>> I think that actually might be better, but that should probably happen
>>> once we actually get repositories for them all. I'm just proposing
>>> this as a first step.
>>>
Re: [Android] Moving plugins to core namespace
Posted by Joe Bowser <bo...@gmail.com>.
It sounds to me like the consensus is to leave them where they are for
now. I'll keep my changes out of master for the time being.
On Fri, Mar 15, 2013 at 2:56 PM, Anis KADRI <an...@gmail.com> wrote:
> So to answer your question it is an automatic process taken care of by
> plugman on installation/uninstallation.
>
>
> On Fri, Mar 15, 2013 at 2:48 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> On Fri, Mar 15, 2013 at 2:41 PM, Anis KADRI <an...@gmail.com> wrote:
>> > What is it that needs to change in the config.xml as far as plugins are
>> > concerned ? I am hoping they will keep the same name and namespace when
>> > they get updated, right ?
>>
>> That's if they get updated. When they get installed, the entry has to
>> be added to the config.xml. Or is that still a manual process?
>>
>> > The only things that should change when plugins
>> > get updated is the native/javascript code and maybe dependencies (but
>> > that's another topic).
>> >
>> > As far as naming everything core, I say why not. I wonder if it's not
>> > preferable to have one directory per plugin instead to make the
>> separation
>> > even more obvious:
>> >
>> > org.apache.cordova.acceleration.Acceleration
>> > org.apache.cordova.capture.Capture
>> > org.apache.cordova.file.File
>> > org.apache.cordova.file.FileTransfer
>> > org.apache.cordova.file.FileProgressResult
>> >
>>
>> I think that actually might be better, but that should probably happen
>> once we actually get repositories for them all. I'm just proposing
>> this as a first step.
>>
Re: [Android] Moving plugins to core namespace
Posted by Anis KADRI <an...@gmail.com>.
So to answer your question it is an automatic process taken care of by
plugman on installation/uninstallation.
On Fri, Mar 15, 2013 at 2:48 PM, Joe Bowser <bo...@gmail.com> wrote:
> On Fri, Mar 15, 2013 at 2:41 PM, Anis KADRI <an...@gmail.com> wrote:
> > What is it that needs to change in the config.xml as far as plugins are
> > concerned ? I am hoping they will keep the same name and namespace when
> > they get updated, right ?
>
> That's if they get updated. When they get installed, the entry has to
> be added to the config.xml. Or is that still a manual process?
>
> > The only things that should change when plugins
> > get updated is the native/javascript code and maybe dependencies (but
> > that's another topic).
> >
> > As far as naming everything core, I say why not. I wonder if it's not
> > preferable to have one directory per plugin instead to make the
> separation
> > even more obvious:
> >
> > org.apache.cordova.acceleration.Acceleration
> > org.apache.cordova.capture.Capture
> > org.apache.cordova.file.File
> > org.apache.cordova.file.FileTransfer
> > org.apache.cordova.file.FileProgressResult
> >
>
> I think that actually might be better, but that should probably happen
> once we actually get repositories for them all. I'm just proposing
> this as a first step.
>
Re: [Android] Moving plugins to core namespace
Posted by Filip Maj <fi...@adobe.com>.
Related to the specific naming and namespaces:
http://wiki.apache.org/cordova/Core%20Plugin%20Name%20Proposal
I don't care on the namespace label. However, I would rather not have to
change it more than over the next few releases. Every time the namespace
of a plugin changes, it requires a longer upgrade guide (As Joe pointed
out). Let's figure out the namespaces in this thread and stick to it (for
all applicable platforms).
On 3/15/13 2:48 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>On Fri, Mar 15, 2013 at 2:41 PM, Anis KADRI <an...@gmail.com> wrote:
>> What is it that needs to change in the config.xml as far as plugins are
>> concerned ? I am hoping they will keep the same name and namespace when
>> they get updated, right ?
>
>That's if they get updated. When they get installed, the entry has to
>be added to the config.xml. Or is that still a manual process?
>
>> The only things that should change when plugins
>> get updated is the native/javascript code and maybe dependencies (but
>> that's another topic).
>>
>> As far as naming everything core, I say why not. I wonder if it's not
>> preferable to have one directory per plugin instead to make the
>>separation
>> even more obvious:
>>
>> org.apache.cordova.acceleration.Acceleration
>> org.apache.cordova.capture.Capture
>> org.apache.cordova.file.File
>> org.apache.cordova.file.FileTransfer
>> org.apache.cordova.file.FileProgressResult
>>
>
>I think that actually might be better, but that should probably happen
>once we actually get repositories for them all. I'm just proposing
>this as a first step.
Re: [Android] Moving plugins to core namespace
Posted by Joe Bowser <bo...@gmail.com>.
On Fri, Mar 15, 2013 at 2:41 PM, Anis KADRI <an...@gmail.com> wrote:
> What is it that needs to change in the config.xml as far as plugins are
> concerned ? I am hoping they will keep the same name and namespace when
> they get updated, right ?
That's if they get updated. When they get installed, the entry has to
be added to the config.xml. Or is that still a manual process?
> The only things that should change when plugins
> get updated is the native/javascript code and maybe dependencies (but
> that's another topic).
>
> As far as naming everything core, I say why not. I wonder if it's not
> preferable to have one directory per plugin instead to make the separation
> even more obvious:
>
> org.apache.cordova.acceleration.Acceleration
> org.apache.cordova.capture.Capture
> org.apache.cordova.file.File
> org.apache.cordova.file.FileTransfer
> org.apache.cordova.file.FileProgressResult
>
I think that actually might be better, but that should probably happen
once we actually get repositories for them all. I'm just proposing
this as a first step.
Re: [Android] Moving plugins to core namespace
Posted by Anis KADRI <an...@gmail.com>.
What is it that needs to change in the config.xml as far as plugins are
concerned ? I am hoping they will keep the same name and namespace when
they get updated, right ? The only things that should change when plugins
get updated is the native/javascript code and maybe dependencies (but
that's another topic).
As far as naming everything core, I say why not. I wonder if it's not
preferable to have one directory per plugin instead to make the separation
even more obvious:
org.apache.cordova.acceleration.Acceleration
org.apache.cordova.capture.Capture
org.apache.cordova.file.File
org.apache.cordova.file.FileTransfer
org.apache.cordova.file.FileProgressResult
etc...
On Fri, Mar 15, 2013 at 2:28 PM, Joe Bowser <bo...@gmail.com> wrote:
> On Fri, Mar 15, 2013 at 2:22 PM, Filip Maj <fi...@adobe.com> wrote:
> > Providing an upgrade path is still something we need to consider.
> >
> > So yes, an upgrade guide that says "change the values of your plugins
> from
> > x to y" is doable. As well as a script that does a global search/replace.
> > Not rocket science.
>
> I definitely think we should add this to the upgrade guide. If
> someone wants to write a script, OK, but it seems like a duplication
> of effort.
>
Re: [Android] Moving plugins to core namespace
Posted by Joe Bowser <bo...@gmail.com>.
On Fri, Mar 15, 2013 at 2:22 PM, Filip Maj <fi...@adobe.com> wrote:
> Providing an upgrade path is still something we need to consider.
>
> So yes, an upgrade guide that says "change the values of your plugins from
> x to y" is doable. As well as a script that does a global search/replace.
> Not rocket science.
I definitely think we should add this to the upgrade guide. If
someone wants to write a script, OK, but it seems like a duplication
of effort.
Re: [Android] Moving plugins to core namespace
Posted by Filip Maj <fi...@adobe.com>.
Providing an upgrade path is still something we need to consider.
So yes, an upgrade guide that says "change the values of your plugins from
x to y" is doable. As well as a script that does a global search/replace.
Not rocket science.
On 3/15/13 2:19 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>Honestly, config.xml is a file that is going to be edited by users
>now, so the last thing that I want to do is get yet another script
>involved, since it could really screw up their config.xml and make
>things even worse. I think we'd be better off giving them a heads up
>when we release this and letting them copy and paste from our template
>config.xml.
>
>Also, once we're done here, plugman is supposed to do this right? :P
>
>On Fri, Mar 15, 2013 at 2:08 PM, Simon MacDonald
><si...@gmail.com> wrote:
>> Do we provide any way to update config. Xml as all of the paths to the
>> plugins will be incorrect? Possibly an update script?
>>
>> Simon
>> On Mar 15, 2013 5:01 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>
>>> Hey
>>>
>>> Since we're working towards making the core plugins installable and
>>> uninstallable, I want to go ahead and move all the plugins to a core
>>> directory so that their Java namespace will be
>>> org.apache.cordova.core. This means that adding and removing will be
>>> less painful for scripts since they shouldn't be messing with anything
>>> that's not a plugin or it's dependency.
>>>
>>> Any thoughts on this before I move things? This shouldn't change the
>>> API at all, and things should continue to work.
>>>
>>> Joe
>>>
Re: [Android] Moving plugins to core namespace
Posted by Joe Bowser <bo...@gmail.com>.
Honestly, config.xml is a file that is going to be edited by users
now, so the last thing that I want to do is get yet another script
involved, since it could really screw up their config.xml and make
things even worse. I think we'd be better off giving them a heads up
when we release this and letting them copy and paste from our template
config.xml.
Also, once we're done here, plugman is supposed to do this right? :P
On Fri, Mar 15, 2013 at 2:08 PM, Simon MacDonald
<si...@gmail.com> wrote:
> Do we provide any way to update config. Xml as all of the paths to the
> plugins will be incorrect? Possibly an update script?
>
> Simon
> On Mar 15, 2013 5:01 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>
>> Hey
>>
>> Since we're working towards making the core plugins installable and
>> uninstallable, I want to go ahead and move all the plugins to a core
>> directory so that their Java namespace will be
>> org.apache.cordova.core. This means that adding and removing will be
>> less painful for scripts since they shouldn't be messing with anything
>> that's not a plugin or it's dependency.
>>
>> Any thoughts on this before I move things? This shouldn't change the
>> API at all, and things should continue to work.
>>
>> Joe
>>
Re: [Android] Moving plugins to core namespace
Posted by Simon MacDonald <si...@gmail.com>.
Do we provide any way to update config. Xml as all of the paths to the
plugins will be incorrect? Possibly an update script?
Simon
On Mar 15, 2013 5:01 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> Hey
>
> Since we're working towards making the core plugins installable and
> uninstallable, I want to go ahead and move all the plugins to a core
> directory so that their Java namespace will be
> org.apache.cordova.core. This means that adding and removing will be
> less painful for scripts since they shouldn't be messing with anything
> that's not a plugin or it's dependency.
>
> Any thoughts on this before I move things? This shouldn't change the
> API at all, and things should continue to work.
>
> Joe
>