[GitHub] [shardingsphere-elasticjob] jiang2015 commented on a change in pull request #1529: Use SPI to initialize JobErrorHandler in test cases #1515/Use mock & verify for EmailJobErrorHandlerTest #1517

[GitBox <gi...@apache.org>]

jiang2015 commented on a change in pull request #1529:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1529#discussion_r497249643



##########
File path: elasticjob-error-handler/elasticjob-error-handler-impl/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatJobErrorHandlerTest.java
##########
@@ -108,6 +110,15 @@ private String getHost() {
         return String.format("http://%s:%s", HOST, PORT);
     }
     
+    private WechatJobErrorHandler getWechatJobErrorHandler() {
+        for (JobErrorHandler jobErrorHandler : ServiceLoader.load(JobErrorHandler.class)) {

Review comment:
       more modified




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org