You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2018/05/25 10:37:31 UTC
[GitHub] zeppelin pull request #2987: ZEPPELIN-3502 Make notebook dynamic forms title...
GitHub user r-kamath opened a pull request:
https://github.com/apache/zeppelin/pull/2987
ZEPPELIN-3502 Make notebook dynamic forms title editable
### What is this PR for?
Make notebook dynamic forms title editable
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3502
### How should this be tested?
Click to edit the title
### Screenshots (if appropriate)
**Before**
<img width="450" alt="screen shot 2018-05-25 at 4 03 20 pm" src="https://user-images.githubusercontent.com/2031306/40540333-5e4c77b8-6035-11e8-9079-bf7cee3dafaf.png">
**After**
<img width="437" alt="screen shot 2018-05-25 at 4 03 37 pm" src="https://user-images.githubusercontent.com/2031306/40540332-5e23f8b0-6035-11e8-85b6-94ae98bad9f6.png">
<img width="423" alt="screen shot 2018-05-25 at 4 03 43 pm" src="https://user-images.githubusercontent.com/2031306/40540331-5df9f1b4-6035-11e8-8b8b-3351f9cbc864.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-3502
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2987.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2987
----
commit cf6f1b2c18ae45cf12dd00557bef17360d63c885
Author: Renjith Kamath <rk...@...>
Date: 2018-05-25T10:31:51Z
ZEPPELIN-3502 Make notebook dynamic forms title editable
Change-Id: I40bac248caaf262a084b7cb40fccd1fd422568f0
----
---
[GitHub] zeppelin pull request #2987: ZEPPELIN-3502 Make notebook dynamic forms title...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2987
---
[GitHub] zeppelin issue #2987: ZEPPELIN-3502 Make notebook dynamic forms title editab...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2987
@zjffdu please review
---
[GitHub] zeppelin issue #2987: ZEPPELIN-3502 Make notebook dynamic forms title editab...
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2987
@r-kamath I have tested. It's nice feature for global dynamic form.
Thank you!
---
[GitHub] zeppelin issue #2987: ZEPPELIN-3502 Make notebook dynamic forms title editab...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2987
will merge this if there are no more discussions
---
[GitHub] zeppelin issue #2987: ZEPPELIN-3502 Make notebook dynamic forms title editab...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2987
@r-kamath I am not familiar with this feature, what is the difference between the notebook dynamic forms title and the paragraph title ?
---
[GitHub] zeppelin issue #2987: ZEPPELIN-3502 Make notebook dynamic forms title editab...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2987
@mebelousov 👍
@zjffdu similar to editing notebook title, but for the global dynamic form.
---