[GitHub] [solr] janhoy commented on a diff in pull request #1496: SOLR-16601: Remove Deprecated Methods from SolrClients

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy commented on code in PR #1496:
URL: https://github.com/apache/solr/pull/1496#discussion_r1150844208


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java:
##########
@@ -116,12 +114,23 @@ protected ConcurrentUpdateSolrClient(Builder builder) {
     this.streamDeletes = builder.streamDeletes;
     this.connectionTimeout = Math.toIntExact(builder.connectionTimeoutMillis);
     this.soTimeout = Math.toIntExact(builder.socketTimeoutMillis);
-    this.stallTime = Integer.getInteger("solr.cloud.client.stallTime", 15000);
-    if (stallTime < pollQueueTime * 2) {
+    this.pollQueueTimeMillis = builder.pollQueueTime;
+    this.stallTimeMillis = Integer.getInteger("solr.cloud.client.stallTime", 15000);
+
+    // make sure the stall time is larger than the polling time
+    // to give a chance for the queue to change
+    int minimalStallTime = pollQueueTimeMillis * 2;
+    if (minimalStallTime > this.stallTimeMillis) {
+      this.stallTimeMillis = minimalStallTime;
+    }

Review Comment:
   Should these changes, and the one below, be in a separate PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org