You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by yo...@apache.org on 2006/08/12 21:14:45 UTC

svn commit: r431076 - in /incubator/solr/trunk/src: java/org/apache/solr/util/OpenBitSet.java test/org/apache/solr/util/TestOpenBitSet.java

Author: yonik
Date: Sat Aug 12 12:14:44 2006
New Revision: 431076

URL: http://svn.apache.org/viewvc?rev=431076&view=rev
Log:
fix OpenBitSet.equals typecheck

Modified:
    incubator/solr/trunk/src/java/org/apache/solr/util/OpenBitSet.java
    incubator/solr/trunk/src/test/org/apache/solr/util/TestOpenBitSet.java

Modified: incubator/solr/trunk/src/java/org/apache/solr/util/OpenBitSet.java
URL: http://svn.apache.org/viewvc/incubator/solr/trunk/src/java/org/apache/solr/util/OpenBitSet.java?rev=431076&r1=431075&r2=431076&view=diff
==============================================================================
--- incubator/solr/trunk/src/java/org/apache/solr/util/OpenBitSet.java (original)
+++ incubator/solr/trunk/src/java/org/apache/solr/util/OpenBitSet.java Sat Aug 12 12:14:44 2006
@@ -655,7 +655,7 @@
   /** returns true if both sets have the same bits set */
   public boolean equals(Object o) {
     if (this == o) return true;
-    if (!(this instanceof OpenBitSet)) return false;
+    if (!(o instanceof OpenBitSet)) return false;
     OpenBitSet a;
     OpenBitSet b = (OpenBitSet)o;
     // make a the larger set.

Modified: incubator/solr/trunk/src/test/org/apache/solr/util/TestOpenBitSet.java
URL: http://svn.apache.org/viewvc/incubator/solr/trunk/src/test/org/apache/solr/util/TestOpenBitSet.java?rev=431076&r1=431075&r2=431076&view=diff
==============================================================================
--- incubator/solr/trunk/src/test/org/apache/solr/util/TestOpenBitSet.java (original)
+++ incubator/solr/trunk/src/test/org/apache/solr/util/TestOpenBitSet.java Sat Aug 12 12:14:44 2006
@@ -137,6 +137,28 @@
     // doRandomSets(2000,200000);
   }
 
+  public void testEquals() {
+    OpenBitSet b1 = new OpenBitSet(1111);
+    OpenBitSet b2 = new OpenBitSet(2222);
+    assertTrue(b1.equals(b2));
+    assertTrue(b2.equals(b1));
+    b1.set(10);
+    assertFalse(b1.equals(b2));
+    assertFalse(b2.equals(b1));
+    b2.set(10);
+    assertTrue(b1.equals(b2));
+    assertTrue(b2.equals(b1));
+    b2.set(2221);
+    assertFalse(b1.equals(b2));
+    assertFalse(b2.equals(b1));
+    b1.set(2221);
+    assertTrue(b1.equals(b2));
+    assertTrue(b2.equals(b1));
+
+    // try different type of object
+    assertFalse(b1.equals(1));
+  }
+
 }