You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by GitBox <gi...@apache.org> on 2022/10/24 14:50:50 UTC

[GitHub] [ambari-metrics] lucasbak opened a new pull request, #48: AMBARI-25320 Backport AMBARI-24872 and AMBARI-24723 for ambari 2.7.4

lucasbak opened a new pull request, #48:
URL: https://github.com/apache/ambari-metrics/pull/48

   ## What changes were proposed in this pull request?
   
   AMBARI-25320 Backport AMBARI-24872 and AMBARI-24723 for ambari 2.7.4
   
   ## How was this patch tested?
   
   back port only
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] lucasbak commented on pull request #48: [AMBARI-25089] NIFI-Hosts dashboard does not show any metrics in Grafana

Posted by GitBox <gi...@apache.org>.
lucasbak commented on PR #48:
URL: https://github.com/apache/ambari-metrics/pull/48#issuecomment-1290300579

   Thanks @kevinw66 for the review.
   Indentation fixed ans title renamed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] kevinw66 merged pull request #48: [AMBARI-25089] NIFI-Hosts dashboard does not show any metrics in Grafana

Posted by GitBox <gi...@apache.org>.
kevinw66 merged PR #48:
URL: https://github.com/apache/ambari-metrics/pull/48


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] kevinw66 commented on pull request #48: AMBARI-25320 Backport AMBARI-24872 and AMBARI-24723 for ambari 2.7.4

Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #48:
URL: https://github.com/apache/ambari-metrics/pull/48#issuecomment-1289898342

   Thanks @lucasbak !
   AMBARI-25230 is a backport commit from AMBARI-25089, which is submitted to here, this is the PR: https://github.com/apache/ambari-metrics/pull/14
   But I can see there are some difference on AMBARI-25230 which committed to `ambari` repository: https://github.com/apache/ambari/pull/3026.
   I think this can be additional commit for AMBARI-25089, so let's change the title to: `[AMBARI-25089] NIFI-Hosts dashboard does not show any metrics in Grafana`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] kevinw66 commented on a diff in pull request #48: AMBARI-25320 Backport AMBARI-24872 and AMBARI-24723 for ambari 2.7.4

Posted by GitBox <gi...@apache.org>.
kevinw66 commented on code in PR #48:
URL: https://github.com/apache/ambari-metrics/pull/48#discussion_r1003938194


##########
ambari-metrics-grafana/ambari-metrics/datasource.js:
##########
@@ -292,8 +292,8 @@ define([
         var getAllHostData = function (target) {
           var instanceId = typeof target.templatedCluster == 'undefined' ? '' : '&instanceId=' + target.templatedCluster;
           var appId = target.app;
-          if ((appId === 'nifi' || appId === 'druid') && !instanceId) {
-            instanceId = "%"
+          if ((appId === 'nifi' || appId === 'druid') && (!instanceId || instanceId === '&instanceId=')) {
+                instanceId = "&instanceId=%"

Review Comment:
   Please use correct indent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org