You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "chtompki (via GitHub)" <gi...@apache.org> on 2023/06/13 21:51:55 UTC
[GitHub] [fineract] chtompki opened a new pull request, #3252: fix(build): make logging warnings clearer
chtompki opened a new pull request, #3252:
URL: https://github.com/apache/fineract/pull/3252
Starting with small non-breaking contributions to clean the code up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #3252: fix(build): make logging warnings clearer
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3252: fix(build): make logging warnings clearer
URL: https://github.com/apache/fineract/pull/3252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #3252: fix(build): make logging warnings clearer
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3252:
URL: https://github.com/apache/fineract/pull/3252#issuecomment-1656480857
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #3252: fix(build): make logging warnings clearer
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #3252:
URL: https://github.com/apache/fineract/pull/3252#issuecomment-1590634781
@chtompki can you please conform the contribution requirements for Fineract? Let's squash your commits, have a FINERACT-XYZ ticket in the title of the PR that your changes are referring to and the same thing for the commit message.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] reluxa commented on a diff in pull request #3252: fix(build): make logging warnings clearer
Posted by "reluxa (via GitHub)" <gi...@apache.org>.
reluxa commented on code in PR #3252:
URL: https://github.com/apache/fineract/pull/3252#discussion_r1244230608
##########
buildSrc/src/main/groovy/org/apache/fineract/gradle/service/GpgService.groovy:
##########
@@ -87,7 +87,7 @@ class GpgService {
this.privateKey = secretKey.extractPrivateKey(new JcePBESecretKeyDecryptorBuilder().setProvider(BouncyCastleProvider.PROVIDER_NAME).build(config.password.toCharArray()))
}
} else {
- log.warn("Could not open the public key ring.")
+ log.warn("WARN: If preparing a fineract release: could not open the public key ring.")
Review Comment:
The GPGService is only used in step7, so we may defer the initialization of the GpgService when that step is executed.
https://github.com/apache/fineract/blob/a90506c7e0841e16932af1c3c69c95166388ad96/buildSrc/src/main/groovy/org/apache/fineract/gradle/FineractPlugin.groovy#L335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org