You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by karensmolermiller <gi...@git.apache.org> on 2017/07/19 17:40:09 UTC

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

GitHub user karensmolermiller opened a pull request:

    https://github.com/apache/geode/pull/644

    GEODE-3208 Revise docs with outdated JAR references

    @joeymcallister @davebarnes97 @kirklund Please review.
    
    Note: While making modifications to satisfy GEODE-3208, I took the liberty of injecting newlines and changing file names to remove the need for horizontal scroll bars in the resulting html, modified IP addresses (to use a "documentation IP address"), and removed a duplicated portion of an example.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karensmolermiller/geode feature/GEODE-3208

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #644
    
----
commit b7f757017d1c0ac7d6622afab2350d6844d889bc
Author: Karen Miller <km...@pivotal.io>
Date:   2017-07-19T17:28:17Z

    GEODE-3208 Revise docs with outdated JAR references

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/644


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

Posted by davebarnes97 <gi...@git.apache.org>.

Github user davebarnes97 commented on a diff in the pull request:

https://github.com/apache/geode/pull/644#discussion_r128331252

--- Diff: geode-docs/tools_modules/gfsh/configuring_gfsh.html.md.erb ---
@@ -24,13 +24,13 @@ The `gfsh.bat` and `gfsh` bash script automatically append the required Apache G

## <a id="concept_3B9C6CE2F64841E98C33D9F6441DF487__section_0D2EEA7A9ED54DFDB2E1EE955E47921E" class="no-quick-link"></a>JAR Libraries in CLASSPATH

-When you start up `gfsh`, it will automatically load required JAR files that have been packaged in the `gfsh-dependencies.jar` file. You do not need to modify your CLASSPATH to run gfsh. When starting servers and locators in gfsh, the start server and start locator commands will load `server-dependencies.jar` and `locator-dependencies.jar` files into the process CLASSPATH for you.
+When you start up `gfsh`, it will automatically load required JAR files that have been packaged in the `gfsh-dependencies.jar` file. You do not need to modify your CLASSPATH to run `gfsh`.

-These dependency JAR files are packaged in your Apache Geode installation in the `$GEMFIRE/lib` (or on Windows, the `%GEODE_HOME%\lib`) directory.
+The JAR files are packaged within your installation directory in the `lib` directory.

## <a id="concept_3B9C6CE2F64841E98C33D9F6441DF487__section_02EEF9A519094EAD9D6B5C8E896EBA27" class="no-quick-link"></a>Machine Hostname

-On some operating systems, you may need to ensure that the hostname of your machine is configured in your system hosts file. For example, on Mac OSX you may need to map your machine's hostname to your IP address in the `/etc/hosts` file in order for `gfsh` and Pulse to operate correctly.
+On some operating systems, you may need to ensure that the host name of your machine is configured in your system hosts file. For example, on Mac OSX you may need to map your machine's host name to your IP address in the `/etc/hosts` file in order for `gfsh` and Pulse to operate correctly.
--- End diff --

LGTM +1

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

Posted by joeymcallister <gi...@git.apache.org>.

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/644#discussion_r128320777

--- Diff: geode-docs/tools_modules/gfsh/configuring_gfsh.html.md.erb ---
@@ -24,13 +24,13 @@ The `gfsh.bat` and `gfsh` bash script automatically append the required Apache G

## <a id="concept_3B9C6CE2F64841E98C33D9F6441DF487__section_0D2EEA7A9ED54DFDB2E1EE955E47921E" class="no-quick-link"></a>JAR Libraries in CLASSPATH

## <a id="concept_3B9C6CE2F64841E98C33D9F6441DF487__section_02EEF9A519094EAD9D6B5C8E896EBA27" class="no-quick-link"></a>Machine Hostname

Isn't "hostname" correct here?