[GitHub] [superset] kgabryje commented on a diff in pull request #22031: feat: Adds more customization properties to DropdownContainer

[GitBox <gi...@apache.org>]

kgabryje commented on code in PR #22031:
URL: https://github.com/apache/superset/pull/22031#discussion_r1014053804


##########
superset-frontend/src/components/DropdownContainer/index.tsx:
##########
@@ -68,10 +71,18 @@ export interface DropdownContainerProps {
    * Option to customize the content of the popover.
    */
   popoverContent?: (overflowedItems: Item[]) => ReactElement;
+  /**
+   * Popover ref.
+   */
+  popoverRef?: RefObject<HTMLDivElement>;
   /**
    * Popover additional style properties.
    */
   popoverStyle?: CSSProperties;
+  /**
+   * Displayed count in the popover trigger.
+   */
+  popoverTriggerCount?: number;

Review Comment:
   I think that we need to display the number of active filters in the dropdown. Since I don't think that the outside components now which filters are in the dropdown, I think that `popoverTriggerCount` needs to be a function that takes the elements in popover as an argument and returns a number. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org