You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/27 22:16:14 UTC

[GitHub] [beam] riteshghorse commented on a diff in pull request #22476: [Go SDK]: Plumb allowed lateness to execution

riteshghorse commented on code in PR #22476:
URL: https://github.com/apache/beam/pull/22476#discussion_r931624777


##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -834,7 +834,7 @@ func (m *marshaller) expandReshuffle(edge NamedEdge) (string, error) {
 				MergeStatus:     pipepb.MergeStatus_NON_MERGING,
 				WindowCoderId:   windowCoderId,
 				ClosingBehavior: pipepb.ClosingBehavior_EMIT_IF_NONEMPTY,
-				AllowedLateness: 0,
+				AllowedLateness: int64(in.From.WindowingStrategy().AllowedLateness),

Review Comment:
   I also wasn't sure about it but Java implementation seems to be preserving the allowed lateness value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org