You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Vincent Lefevre <vi...@vinc17.net> on 2022/03/11 10:08:26 UTC
http URLs should be updated to https
When running "svn --help", I get:
[...]
For additional information, see http://subversion.apache.org/
This URL should be updated to https, and probably other instances
in the Subversion source.
http://svnbook.red-bean.com is also concerned.
Even though the websites automatically redirect to https, using
https URLs directly has at least 2 advantages:
* this redirection is not always protected against man-in-the-middle
attacks;
* using https would be a bit faster (by skipping the redirection).
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: http URLs should be updated to https
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Vincent Lefevre wrote on Fri, Mar 11, 2022 at 12:09:59 +0100:
> On 2022-03-11 10:29:12 +0000, Julian Foad wrote:
> > Julian Foad wrote:
> > > +1. Can you send a patch?
> >
> > By the way, the reason I ask if you would be willing, rather than "just
> > quickly doing it" myself, is even a small "obvious" fix like this tends
> > to require more than it initially looks like: checking if it's already
> > done in head of trunk,
>
> This is what I'm looking at.
>
> > finding other similar places,
>
> I typically do a recursive grep to find the potential updates to be
> done.
>
> > deciding if any of them shouldn't be updated for whatever reason,
> > running the test suite, adjusting test results to match...
>
> Yes, this requires some time to do it well (I've already done such
> kinds of changes in another project), mainly for checking. I suppose
> that eveything the end user can see needs to be updated, but also
> for the readers of the source code, e.g. comments like
>
> # See http://subversion.apache.org for more information.
+1
> I have a question for 2 kinds of files. I think that the URLs should
> be updated too in these files, but I need confirmation:
> * The "CHANGES" file.
Most instances can be changed, yes, but some instances of "http://" are
shorthand for "any http://* or https://*" URL and should probably be
left alone. And naturally, http://third-party.example.com/ stuff
shouldn't be changed unless the new value is verified to work.
> * The .po files. The advantage is that this would avoid the need of
> the update by the translators. A potential drawback is that the
> additional character might need to adjust the formatting, e.g. to
> fit on 80 columns where applicable (there aren't many concerned
> lines, so that I could report any such formatting issue).
+1 and thank you.
Instead of reporting them, it might be easier for you to just leave the
entire msgid/msgstr pair untouched. We could then generate a list of
the remaining issues by grepping again, and the translator would notice
the out-of-date message when they next update the translation.
Cheers,
Daniel
Re: [PATCH] URL update to https
Posted by Nathan Hartman <ha...@gmail.com>.
On Fri, Aug 19, 2022 at 2:36 PM Daniel Sahlberg
<da...@gmail.com> wrote:
>
> Nathan & Vincent,
>
> Great work both of you! Thanks for taking care of this!
>
> /Daniel
Thanks! And thanks for doing the same for the svn-book!
Cheers,
Nathan
Re: [PATCH] URL update to https
Posted by Daniel Sahlberg <da...@gmail.com>.
Nathan & Vincent,
Great work both of you! Thanks for taking care of this!
/Daniel
Den fre 19 aug. 2022 19:01Nathan Hartman <ha...@gmail.com> skrev:
> On Fri, Aug 19, 2022 at 12:52 PM Nathan Hartman
> <ha...@gmail.com> wrote:
> > On Sun, Aug 14, 2022 at 7:02 AM Vincent Lefevre <vi...@vinc17.net>
> wrote:
> > > * In tools/examples/svnlook.py, the anchor in
> > > https://subversion.apache.org/docs/community-guide/#docs
> > > no longer exists.
> >
> > This one will take a little bit of digging through the history to
> > figure out whether a #docs anchor ever existed and, if so, what
> > section of HACKING it referred to. That is, did it just refer to
> > HACKING as a whole, or to a section describing the delta editor?
>
> I see what happened. The anchor is OK, but the link was wrong. Fixed
> in r1903580.
>
> Cheers,
> Nathan
>
Re: [PATCH] URL update to https
Posted by Nathan Hartman <ha...@gmail.com>.
On Fri, Aug 19, 2022 at 12:52 PM Nathan Hartman
<ha...@gmail.com> wrote:
> On Sun, Aug 14, 2022 at 7:02 AM Vincent Lefevre <vi...@vinc17.net> wrote:
> > * In tools/examples/svnlook.py, the anchor in
> > https://subversion.apache.org/docs/community-guide/#docs
> > no longer exists.
>
> This one will take a little bit of digging through the history to
> figure out whether a #docs anchor ever existed and, if so, what
> section of HACKING it referred to. That is, did it just refer to
> HACKING as a whole, or to a section describing the delta editor?
I see what happened. The anchor is OK, but the link was wrong. Fixed
in r1903580.
Cheers,
Nathan
Re: [PATCH] URL update to https
Posted by Nathan Hartman <ha...@gmail.com>.
On Wed, Aug 17, 2022 at 10:21 PM Vincent Lefevre <vi...@vinc17.net> wrote:
>
> On 2022-08-17 13:16:42 -0400, Nathan Hartman wrote:
> > Looks good to me. Thanks for doing that. I'll commit it shortly.
> >
> > Is there anything in particular you'd like the log message to say (other
> > than credit for writing this patch of course)?
>
> Nothing particular. Thanks.
Committed in r1903577.
Also:
On Sun, Aug 14, 2022 at 7:02 AM Vincent Lefevre <vi...@vinc17.net> wrote:
> * In the following files
> notes/commit-access-templates/full-committer.tmpl
> notes/commit-access-templates/partial-committer.tmpl
> notes/commit-access-templates/pmc-member.tmpl
> the anchor in https://www.apache.org/dev/new-committers-guide.html#cla
> no longer exists.
Fixed in r1903578.
> * In notes/api-errata/1.7/ra001.txt, change
> https://subversion.apache.org/docs/api/latest/structsvn__delta__editor__t.html#_details
> to
> https://subversion.apache.org/docs/api/latest/structsvn__delta__editor__t.html#details
Fixed in r1903579.
> * In tools/examples/svnlook.py, the anchor in
> https://subversion.apache.org/docs/community-guide/#docs
> no longer exists.
This one will take a little bit of digging through the history to
figure out whether a #docs anchor ever existed and, if so, what
section of HACKING it referred to. That is, did it just refer to
HACKING as a whole, or to a section describing the delta editor?
Cheers,
Nathan
Re: [PATCH] URL update to https
Posted by Vincent Lefevre <vi...@vinc17.net>.
On 2022-08-17 13:16:42 -0400, Nathan Hartman wrote:
> Looks good to me. Thanks for doing that. I'll commit it shortly.
>
> Is there anything in particular you'd like the log message to say (other
> than credit for writing this patch of course)?
Nothing particular. Thanks.
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: [PATCH] URL update to https
Posted by Nathan Hartman <ha...@gmail.com>.
On Wed, Aug 17, 2022 at 9:55 AM Vincent Lefevre <vi...@vinc17.net>
wrote:
> On 2022-08-14 10:56:07 -0400, Nathan Hartman wrote:
> > I'm attaching an updated patch with the following changes:
> >
> > (1) Revert LICENSE
> > (2) Revert the license headers
>
> Your patch adds a trailing newline to 2 files:
> subversion/tests/cmdline/svneditor.bat
> tools/buildbot/slaves/win32-vcpkg/svntest-build.cmd
Ironic that when I removed that from the other four files, I added it to
these two. Good catch!
I've attached a new patch obtained with
>
> perl -pi -e \
> 's[http://(subversion\.apache\.org|svnbook\.red-bean\.com)]
> [https://\1];
> s[http://(www.apache.org)(?!/licenses)]
> [https://\1]' **/*(.)
>
> and the manual formatting improvements on
>
> subversion/libsvn_repos/repos.c
> tools/dev/contribulyze.py
>
> This corresponds to your patch without the added trailing newlines.
Looks good to me. Thanks for doing that. I'll commit it shortly.
Is there anything in particular you'd like the log message to say (other
than credit for writing this patch of course)?
Cheers,
Nathan
Re: [PATCH] URL update to https
Posted by Vincent Lefevre <vi...@vinc17.net>.
On 2022-08-14 10:56:07 -0400, Nathan Hartman wrote:
> I'm attaching an updated patch with the following changes:
>
> (1) Revert LICENSE
> (2) Revert the license headers
Your patch adds a trailing newline to 2 files:
subversion/tests/cmdline/svneditor.bat
tools/buildbot/slaves/win32-vcpkg/svntest-build.cmd
I've attached a new patch obtained with
perl -pi -e \
's[http://(subversion\.apache\.org|svnbook\.red-bean\.com)]
[https://\1];
s[http://(www.apache.org)(?!/licenses)]
[https://\1]' **/*(.)
and the manual formatting improvements on
subversion/libsvn_repos/repos.c
tools/dev/contribulyze.py
This corresponds to your patch without the added trailing newlines.
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: [BUG] svn patch with svn:eol-style set to native
Posted by Vincent Lefevre <vi...@vinc17.net>.
On 2022-08-15 10:06:48 -0400, Nathan Hartman wrote:
> On Sun, Aug 14, 2022 at 8:08 PM Vincent Lefevre <vi...@vinc17.net> wrote:
> > printf %s "$(printf "%d\n" `seq 2 8`)" > file
>
> One thing I don't understand about the above is why does the outer
> printf %s strip the last newline from the inner one?
It is the $(...) that strips the trailing newline(s):
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_03
That's why I've used that.
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: [BUG] svn patch with svn:eol-style set to native
Posted by Nathan Hartman <ha...@gmail.com>.
On Mon, Aug 15, 2022 at 10:06 AM Nathan Hartman
<ha...@gmail.com> wrote:
> I'll file an issue in the issue tracker...
Filed: https://issues.apache.org/jira/browse/SVN-4906
Cheers,
Nathan
Re: [BUG] svn patch with svn:eol-style set to native
Posted by Nathan Hartman <ha...@gmail.com>.
On Sun, Aug 14, 2022 at 8:08 PM Vincent Lefevre <vi...@vinc17.net> wrote:
>
> About this bug:
>
> On 2022-08-14 14:11:15 -0400, Nathan Hartman wrote:
> > But applying your original patch to a clean working copy and then
> > running 'svn diff' does show it -- note the - and + of </Project> and
> > "\ No newline at end of file" at the end of the output:
> [...]
> > That looks like a bug in SVN. This machine (the one I'm using now) has
> > 1.13.0 so I'll try this with 1.14.2 later...
>
> I can reproduce the issue with svn 1.14.2, and this is due to
> svn:eol-style being set to native.
Nice catch!
Thanks for the reproduction script.
The issue: When the file has the svn:eol-style property set and the
last line of the file does not end with a newline, 'svn patch' adds a
newline to the last line of the file, even when the diff does not call
for it.
I've confirmed that the same issue is reproduced for all possible
svn:eol-style settings. (I did that by using the reproduction script
as-is, and then also modifying it to try the other svn:eol-style
settings of CRLF, LF, and CR.)
I went through the issue tracker looking for similar issues. SVN-3556
and SVN-3991 are *not* similar, but I'm making a note of them here as
they may be relevant. In particular, SVN-3991 seems to be somewhat a
reverse of this issue, where the patch file, rather than the file
being patched, lacks a last newline.
For reference, this was found during the recent dev@s.a.o mail thread
"[PATCH] URL update to https" -- see the part starting with "Are you
sure" in 14 August 2022 message:
https://lists.apache.org/thread/w0fld2p0qzg5oo6tqgw1tcvtolndvg9t
I'll file an issue in the issue tracker...
> printf %s "$(printf "%d\n" `seq 2 8`)" > file
One thing I don't understand about the above is why does the outer
printf %s strip the last newline from the inner one?
Cheers,
Nathan
[BUG] svn patch with svn:eol-style set to native
Posted by Vincent Lefevre <vi...@vinc17.net>.
About this bug:
On 2022-08-14 14:11:15 -0400, Nathan Hartman wrote:
> But applying your original patch to a clean working copy and then
> running 'svn diff' does show it -- note the - and + of </Project> and
> "\ No newline at end of file" at the end of the output:
[...]
> That looks like a bug in SVN. This machine (the one I'm using now) has
> 1.13.0 so I'll try this with 1.14.2 later...
I can reproduce the issue with svn 1.14.2, and this is due to
svn:eol-style being set to native.
To reproduce:
------------------------------------------------------------
#!/bin/sh
set -ex
svn --version
mkdir my-test-svn
cd my-test-svn
svnadmin create svn
root=file://`pwd`/svn
svn co "$root" wc
cd wc
printf %s "$(printf "%d\n" `seq 8`)" > file
svn add file
svn ps svn:eol-style native file
svn ci -m 'add file'
printf %s "$(printf "%d\n" `seq 2 8`)" > file
svn diff > file.patch
cat file.patch
svn revert file
svn patch file.patch
svn diff
cd ../..
rm -rf my-test-svn
------------------------------------------------------------
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: [PATCH] URL update to https
Posted by Nathan Hartman <ha...@gmail.com>.
On Sun, Aug 14, 2022 at 11:57 AM Vincent Lefevre <vi...@vinc17.net> wrote:
> > [1] Those files are:
> > build/generator/templates/svn_config.vcxproj.ezt
> > build/generator/templates/svn_locale.vcxproj.ezt
> > build/generator/templates/vcnet_vcxproj_filters.ezt
> > subversion/libsvn_subr/win32_crashrpt_dll.h
>
> Are you sure? I cannot see any such change in my patch.
> Couldn't this be the result of the revert of the licence
> headers?
This is weird.
Looking inside your original patch, in fact the patch does not change
those last lines.
But applying your original patch to a clean working copy and then
running 'svn diff' does show it -- note the - and + of </Project> and
"\ No newline at end of file" at the end of the output:
[[[
$ svn patch --quiet subversion-url.patch
$ svn diff build/generator/templates/svn_config.vcxproj.ezt
Index: build/generator/templates/svn_config.vcxproj.ezt
===================================================================
--- build/generator/templates/svn_config.vcxproj.ezt (revision 1903314)
+++ build/generator/templates/svn_config.vcxproj.ezt (working copy)
@@ -8,7 +8,7 @@
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
+ https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
@@ -78,4 +78,4 @@
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Label="ExtensionTargets">
</ImportGroup>
-</Project>
\ No newline at end of file
+</Project>
]]]
That looks like a bug in SVN. This machine (the one I'm using now) has
1.13.0 so I'll try this with 1.14.2 later...
Cheers,
Nathan
Re: [PATCH] URL update to https
Posted by Vincent Lefevre <vi...@vinc17.net>.
On 2022-08-14 10:56:07 -0400, Nathan Hartman wrote:
> Regarding LICENSE, I also think it should remain identical.
OK (if a change is needed, perhaps Apache could do it first, like
what the FSF did for GPLv3, in 2017 IIRC). However, I think that
there would be no problems to update the license location in
source files.
> Regarding URLs that became incorrect for other reasons, e.g.,
> https://www.apache.org/dev/new-committers-guide.html#cla, I think
> those should be addressed in separate patches...
[...]
This is also what I think.
> I'm attaching an updated patch with the following changes:
>
> (1) Revert LICENSE
> (2) Revert the license headers
> (3) In a few files [1], no URLs were changed but a newline was added
> to the end of the file, which wasn't there before. I think this should
> be done in a separate patch.
>
> Please check the updated patch...
I'll look at it later.
> [1] Those files are:
> build/generator/templates/svn_config.vcxproj.ezt
> build/generator/templates/svn_locale.vcxproj.ezt
> build/generator/templates/vcnet_vcxproj_filters.ezt
> subversion/libsvn_subr/win32_crashrpt_dll.h
Are you sure? I cannot see any such change in my patch.
Couldn't this be the result of the revert of the licence
headers?
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: [PATCH] URL update to https
Posted by Nathan Hartman <ha...@gmail.com>.
On Sun, Aug 14, 2022 at 7:35 AM Yasuhito FUTATSUKI
<fu...@yf.bsdclub.org> wrote:
>
> Hello,
>
> On 2022/08/14 20:02, Vincent Lefevre wrote:
> > Hi,
> >
> > Following the thread "http URLs should be updated to https",
> > I've attached a patch that changes the http URLs to https for
> > the following hostnames:
> >
> > subversion.apache.org
> > www.apache.org
> > svnbook.red-bean.com
> >
> > This has been done with
> >
> > perl -pi -e \
> > 's[http://((subversion|www)\.apache\.org|svnbook\.red-bean\.com)]
> > [https://\1]' **/*(.)
> >
> > from the working copy (trunk), thus including the po files.
>
> I think the first part of LICENSE file shoud be equal to
> https://www.apache.org/licenses/LICENSE-2.0.txt, so we should not
> change the URLs in it.
>
> (I didn't check wheter other changes are safe or not.)
>
> Cheers,
> --
> Yasuhito FUTATSUKI <fu...@yf.bsclub.org>
First of all, thank you, Vincent, for doing this.
Regarding LICENSE, I also think it should remain identical.
That brings me to the license header at the top of each source file, e.g.:
# ====================================================================
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
# ====================================================================
(With the appropriate comment markers for the file's programming
language, of course.)
I don't know whether we can change that text. For now, I think we
should leave it as-is (but I'll be happy to ask legal@ if we have a
strong desire to change it; let me know).
The rest of the changes look good to me.
Regarding the files in contrib, we don't really maintain them, but I
think it's OK to update http:// URLs to https://.
Regarding URLs that became incorrect for other reasons, e.g.,
https://www.apache.org/dev/new-committers-guide.html#cla, I think
those should be addressed in separate patches... (I have a feeling
someone deleted the #cla pilcrow on that page by mistake, so perhaps
that should be fixed; but since the page isn't too long of a read,
maybe we should just drop the #cla anchor from our link anyway).
I'm attaching an updated patch with the following changes:
(1) Revert LICENSE
(2) Revert the license headers
(3) In a few files [1], no URLs were changed but a newline was added
to the end of the file, which wasn't there before. I think this should
be done in a separate patch.
Please check the updated patch...
[1] Those files are:
build/generator/templates/svn_config.vcxproj.ezt
build/generator/templates/svn_locale.vcxproj.ezt
build/generator/templates/vcnet_vcxproj_filters.ezt
subversion/libsvn_subr/win32_crashrpt_dll.h
Cheers,
Nathan
Re: [PATCH] URL update to https
Posted by Yasuhito FUTATSUKI <fu...@yf.bsdclub.org>.
Hello,
On 2022/08/14 20:02, Vincent Lefevre wrote:
> Hi,
>
> Following the thread "http URLs should be updated to https",
> I've attached a patch that changes the http URLs to https for
> the following hostnames:
>
> subversion.apache.org
> www.apache.org
> svnbook.red-bean.com
>
> This has been done with
>
> perl -pi -e \
> 's[http://((subversion|www)\.apache\.org|svnbook\.red-bean\.com)]
> [https://\1]' **/*(.)
>
> from the working copy (trunk), thus including the po files.
I think the first part of LICENSE file shoud be equal to
https://www.apache.org/licenses/LICENSE-2.0.txt, so we should not
change the URLs in it.
(I didn't check wheter other changes are safe or not.)
Cheers,
--
Yasuhito FUTATSUKI <fu...@yf.bsclub.org>
[PATCH] URL update to https
Posted by Vincent Lefevre <vi...@vinc17.net>.
Hi,
Following the thread "http URLs should be updated to https",
I've attached a patch that changes the http URLs to https for
the following hostnames:
subversion.apache.org
www.apache.org
svnbook.red-bean.com
This has been done with
perl -pi -e \
's[http://((subversion|www)\.apache\.org|svnbook\.red-bean\.com)]
[https://\1]' **/*(.)
from the working copy (trunk), thus including the po files.
In addition to these changes, I have corrected the alignment of NL in
subversion/libsvn_repos/repos.c for the 2 concerned URLs and slightly
reformatted the text in tools/dev/contribulyze.py so that the
corresponding output fits again in 80 columns.
Note that the URLs of the LICENSE file are updated in this patch
while they haven't changed upstream. But since this doesn't change
the license itself, I suppose that this is correct.
I haven't changed the quoted http URL from tools/dev/check-license.py
manually ("http://www\.apache\.org/licenses/LICENSE-2\.0", not matched
by the above regexp) because this appears to be obsolete.
A "make check" here gives
Summary of test results:
2554 tests PASSED
162 tests SKIPPED
81 tests XFAILED (17 WORK-IN-PROGRESS)
In my checks, I've also found URL anchors that became incorrect in
the past (this is unrelated to this patch) and could be fixed in a
separate commit:
* In notes/api-errata/1.7/ra001.txt, change
https://subversion.apache.org/docs/api/latest/structsvn__delta__editor__t.html#_details
to
https://subversion.apache.org/docs/api/latest/structsvn__delta__editor__t.html#details
* In the following files
notes/commit-access-templates/full-committer.tmpl
notes/commit-access-templates/partial-committer.tmpl
notes/commit-access-templates/pmc-member.tmpl
the anchor in https://www.apache.org/dev/new-committers-guide.html#cla
no longer exists.
* In tools/examples/svnlook.py, the anchor in
https://subversion.apache.org/docs/community-guide/#docs
no longer exists.
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: http URLs should be updated to https
Posted by Vincent Lefevre <vi...@vinc17.net>.
On 2022-05-08 17:51:30 +0200, Daniel Sahlberg wrote:
> Den fre 11 mars 2022 kl 12:10 skrev Vincent Lefevre <vincent-svn@vinc17.net
> >:
>
> > On 2022-03-11 10:29:12 +0000, Julian Foad wrote:
> > > Julian Foad wrote:
> > > > +1. Can you send a patch?
> > >
> > > By the way, the reason I ask if you would be willing, rather than "just
> > > quickly doing it" myself, is even a small "obvious" fix like this tends
> > > to require more than it initially looks like: checking if it's already
> > > done in head of trunk,
> >
> > This is what I'm looking at.
> >
>
> Hi Vincent,
>
> Did you get around to do anything about this? Even if you didn't complete
> it, maybe we can commit part of the job.
[...]
Hi Daniel,
Sorry for the late reply. I got busy for the past few months.
But I can now look at it.
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: http URLs should be updated to https
Posted by Daniel Sahlberg <da...@gmail.com>.
Den fre 11 mars 2022 kl 12:10 skrev Vincent Lefevre <vincent-svn@vinc17.net
>:
> On 2022-03-11 10:29:12 +0000, Julian Foad wrote:
> > Julian Foad wrote:
> > > +1. Can you send a patch?
> >
> > By the way, the reason I ask if you would be willing, rather than "just
> > quickly doing it" myself, is even a small "obvious" fix like this tends
> > to require more than it initially looks like: checking if it's already
> > done in head of trunk,
>
> This is what I'm looking at.
>
Hi Vincent,
Did you get around to do anything about this? Even if you didn't complete
it, maybe we can commit part of the job.
>
> > finding other similar places,
>
> I typically do a recursive grep to find the potential updates to be
> done.
>
> > deciding if any of them shouldn't be updated for whatever reason,
> > running the test suite, adjusting test results to match...
>
> Yes, this requires some time to do it well (I've already done such
> kinds of changes in another project), mainly for checking. I suppose
> that eveything the end user can see needs to be updated, but also
> for the readers of the source code, e.g. comments like
>
> # See http://subversion.apache.org for more information.
>
> I have a question for 2 kinds of files. I think that the URLs should
> be updated too in these files, but I need confirmation:
> * The "CHANGES" file.
>
I think it is reasonable. There is also a link to subversion.tigris.org,
the old-old mailinglist. The message can probably be found in
lists.apache.org but it might take a bit of time to investigate exactly
what message was linked originally.
> * The .po files. The advantage is that this would avoid the need of
> the update by the translators. A potential drawback is that the
> additional character might need to adjust the formatting, e.g. to
> fit on 80 columns where applicable (there aren't many concerned
> lines, so that I could report any such formatting issue).
>
This is probably also a good idea. 80-column overflows can be reported (and
potentially ignored if you don't want to get into it).
Kind regards,
Daniel
Re: http URLs should be updated to https
Posted by Vincent Lefevre <vi...@vinc17.net>.
On 2022-03-11 10:29:12 +0000, Julian Foad wrote:
> Julian Foad wrote:
> > +1. Can you send a patch?
>
> By the way, the reason I ask if you would be willing, rather than "just
> quickly doing it" myself, is even a small "obvious" fix like this tends
> to require more than it initially looks like: checking if it's already
> done in head of trunk,
This is what I'm looking at.
> finding other similar places,
I typically do a recursive grep to find the potential updates to be
done.
> deciding if any of them shouldn't be updated for whatever reason,
> running the test suite, adjusting test results to match...
Yes, this requires some time to do it well (I've already done such
kinds of changes in another project), mainly for checking. I suppose
that eveything the end user can see needs to be updated, but also
for the readers of the source code, e.g. comments like
# See http://subversion.apache.org for more information.
I have a question for 2 kinds of files. I think that the URLs should
be updated too in these files, but I need confirmation:
* The "CHANGES" file.
* The .po files. The advantage is that this would avoid the need of
the update by the translators. A potential drawback is that the
additional character might need to adjust the formatting, e.g. to
fit on 80 columns where applicable (there aren't many concerned
lines, so that I could report any such formatting issue).
--
Vincent Lefèvre <vi...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Re: http URLs should be updated to https
Posted by Julian Foad <ju...@apache.org>.
Julian Foad wrote:
> +1. Can you send a patch?
By the way, the reason I ask if you would be willing, rather than "just
quickly doing it" myself, is even a small "obvious" fix like this tends
to require more than it initially looks like: checking if it's already
done in head of trunk, finding other similar places, deciding if any of
them shouldn't be updated for whatever reason, running the test suite,
adjusting test results to match...
Re: http URLs should be updated to https
Posted by Julian Foad <ju...@apache.org>.
+1. Can you send a patch?
- Julian