[jira] [Resolved] (MYFACES-4648) PushContextImpl - different behaviour when socket is not connected

["Thomas Andraschko (Jira)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/MYFACES-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Andraschko resolved MYFACES-4648.
----------------------------------------
    Resolution: Fixed

Thanks,
Great contribution as always

> PushContextImpl - different behaviour when socket is not connected
> ------------------------------------------------------------------
>
>                 Key: MYFACES-4648
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4648
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: General
>    Affects Versions: 4.0.1, 4.0.2, 4.1.0, 5.0.0
>            Reporter: Milan Siebenbürger
>            Priority: Minor
>             Fix For: 4.0.2, 4.1.0, 5.0.0
>
>
> Hi,
> when sending a message via PushContextImpl, the behaviour differs when using methods with or without user specification.
> A new FacesException is thrown when the send() method is used without a user specification and without an open channel:
> {code:java}
> throw new FacesException("CDI bean not found for push message");{code}
> When using send() with a user specified, an empty HashMap is returned.
>  
> I think the behavior should be the same - either Exception (not recommended) or an empty result.
>  
> What do you think about this? I am able to prepare a PR (for whatever version you need), but let me know what result you chose.
>  
> Br
> Milan
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)