You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Shazron Abdullah (JIRA)" <ji...@apache.org> on 2012/11/15 00:26:12 UTC
[jira] [Created] (CB-1850) Add device.model to the Device API
Shazron Abdullah created CB-1850:
------------------------------------
Summary: Add device.model to the Device API
Key: CB-1850
URL: https://issues.apache.org/jira/browse/CB-1850
Project: Apache Cordova
Issue Type: Task
Reporter: Shazron Abdullah
Fix For: 2.3.0
Add device.model to the Device API.
This would identify the exact model of the device, for example iPad2,5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1850) Add device.model to the Device API
Posted by "Jesse MacFadyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497804#comment-13497804 ]
Jesse MacFadyen commented on CB-1850:
-------------------------------------
Can we get more details on what this value should contain? For Android, or Windows Phone, ...
iOS devices are ALL made by Apple, should other platforms include manufacturer, OS version, ...
It may make sense to fully document the DeviceAPI so we all have a verbose definition to work from.
> Add device.model to the Device API
> ----------------------------------
>
> Key: CB-1850
> URL: https://issues.apache.org/jira/browse/CB-1850
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Shazron Abdullah
> Fix For: 2.3.0
>
>
> Add device.model to the Device API.
> This would identify the exact model of the device, for example iPad2,5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1850) Add device.model to the Device API
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500548#comment-13500548 ]
Joe Bowser commented on CB-1850:
--------------------------------
How is this different than device.name? Are we just renaming this?
> Add device.model to the Device API
> ----------------------------------
>
> Key: CB-1850
> URL: https://issues.apache.org/jira/browse/CB-1850
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Shazron Abdullah
> Fix For: 2.3.0
>
>
> Add device.model to the Device API.
> This would identify the exact model of the device, for example iPad2,5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1850) Add device.model to the Device API
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497812#comment-13497812 ]
Shazron Abdullah commented on CB-1850:
--------------------------------------
Basically device.model should be what device.name was before, and we deprecate device.name. There was a discussion in callback-dev, long thread "iOS' Device API".
iOS' device.name was wrong, it should contain the model (it had the name as assigned in iTunes). All the other platforms were correct for device.name.
> Add device.model to the Device API
> ----------------------------------
>
> Key: CB-1850
> URL: https://issues.apache.org/jira/browse/CB-1850
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Shazron Abdullah
> Fix For: 2.3.0
>
>
> Add device.model to the Device API.
> This would identify the exact model of the device, for example iPad2,5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1850) Add device.model to the Device API
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500558#comment-13500558 ]
Shazron Abdullah commented on CB-1850:
--------------------------------------
ML discussion: http://markmail.org/thread/ja7kixjlu6gei7kb
Essentially yes, device.name is device.model now, and device.name is to be deprecated.
> Add device.model to the Device API
> ----------------------------------
>
> Key: CB-1850
> URL: https://issues.apache.org/jira/browse/CB-1850
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Shazron Abdullah
> Fix For: 2.3.0
>
>
> Add device.model to the Device API.
> This would identify the exact model of the device, for example iPad2,5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1850) Add device.model to the Device API
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510868#comment-13510868 ]
Joe Bowser commented on CB-1850:
--------------------------------
One is only slightly less cryptic than the other. I'll make name to be product and model to be model. Since we have 6 months to support name, I think this will be a good time to see WTF is going on with Android Product vs Model. :P
> Add device.model to the Device API
> ----------------------------------
>
> Key: CB-1850
> URL: https://issues.apache.org/jira/browse/CB-1850
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Shazron Abdullah
> Fix For: 2.3.0
>
>
> Add device.model to the Device API.
> This would identify the exact model of the device, for example iPad2,5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1850) Add device.model to the Device API
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497583#comment-13497583 ]
Shazron Abdullah commented on CB-1850:
--------------------------------------
Tentatively set to 2.3.0 - if we can't make it for then, bump to 2.4.0.
> Add device.model to the Device API
> ----------------------------------
>
> Key: CB-1850
> URL: https://issues.apache.org/jira/browse/CB-1850
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Shazron Abdullah
> Fix For: 2.3.0
>
>
> Add device.model to the Device API.
> This would identify the exact model of the device, for example iPad2,5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1850) Add device.model to the Device API
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510859#comment-13510859 ]
Filip Maj commented on CB-1850:
-------------------------------
On this topic. Android has a concept of both device PRODUCT NAME and MODEL:
http://developer.android.com/reference/android/os/Build.html#MODEL (and PRODUCT right below it)
My suggestion would be to have Android use {{android.os.Build.MODEL}} as it corresponds to the "end-user-visible product name." This is what we should be gunning for IMO.
> Add device.model to the Device API
> ----------------------------------
>
> Key: CB-1850
> URL: https://issues.apache.org/jira/browse/CB-1850
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Shazron Abdullah
> Fix For: 2.3.0
>
>
> Add device.model to the Device API.
> This would identify the exact model of the device, for example iPad2,5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira