You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by "mkitti (via GitHub)" <gi...@apache.org> on 2024/02/03 07:01:55 UTC
[PR] Add classifier to extra info [ant-ivy]
mkitti opened a new pull request, #99:
URL: https://github.com/apache/ant-ivy/pull/99
Currenty ivy does not include the classifier as a key for extra information. This pull request adds classifier to the extra info key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Add classifier to extra info [ant-ivy]
Posted by "mkitti (via GitHub)" <gi...@apache.org>.
mkitti commented on PR #99:
URL: https://github.com/apache/ant-ivy/pull/99#issuecomment-2755661254
I'll follow up on Jira. I suspect that users may need to wipe out their IVY cache to use the new key format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Add classifier to extra info [ant-ivy]
Posted by "maartenc (via GitHub)" <gi...@apache.org>.
maartenc closed pull request #99: Add classifier to extra info
URL: https://github.com/apache/ant-ivy/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Add classifier to extra info [ant-ivy]
Posted by "mkitti (via GitHub)" <gi...@apache.org>.
mkitti commented on PR #99:
URL: https://github.com/apache/ant-ivy/pull/99#issuecomment-2592138988
I described the issue here:
https://lists.apache.org/thread/j2gw1rt1xl9f4126cmhqb9gd2oz51c4k
> When adding the dependency org.janelia.saalfeld.lab.n5-ij [2] Ivy does not correctly recognize net.imglib2.imglib2 [3] as a compile dependency. This is because when processing the parent POM (pom-scijava [4]), Ivy only stores extra information with a groupId__artifactId key without the classifier. The initial fix I have produced is to modify the key to include the classifier: groupId__artifiactId__classifierId. I have prototyped these changes on a Github fork [5]. I would like to discuss how we might upstream these changes to Apache Ivy.
[2] https://github.com/saalfeldlab/n5-ij
[3] https://github.com/imglib/imglib2
[4] https://github.com/scijava/pom-scijava
[5] https://github.com/mkitti/ant-ivy/commits/mkitti-maven-classifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Add classifier to extra info [ant-ivy]
Posted by "mkitti (via GitHub)" <gi...@apache.org>.
mkitti commented on PR #99:
URL: https://github.com/apache/ant-ivy/pull/99#issuecomment-2592153054
Essentially, Ivy is not resolving transient dependencies the same way Maven does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Add classifier to extra info [ant-ivy]
Posted by "maartenc (via GitHub)" <gi...@apache.org>.
maartenc commented on PR #99:
URL: https://github.com/apache/ant-ivy/pull/99#issuecomment-2755530399
Hi @mkitti , I've finally pushed a fix based on your pull request.
Thanks for your contribution!
I've added your name to the contributors list as well, give me a ping if you don't want that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Add classifier to extra info [ant-ivy]
Posted by "maartenc (via GitHub)" <gi...@apache.org>.
maartenc commented on PR #99:
URL: https://github.com/apache/ant-ivy/pull/99#issuecomment-2755533052
For the record, the corresponding JIRA issue is: https://issues.apache.org/jira/browse/IVY-1654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Add classifier to extra info [ant-ivy]
Posted by "maartenc (via GitHub)" <gi...@apache.org>.
maartenc commented on PR #99:
URL: https://github.com/apache/ant-ivy/pull/99#issuecomment-2591192927
Thanks for your contribution.
Could you elaborate a bit more what problem you are trying to fix here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Add classifier to extra info [ant-ivy]
Posted by "mkitti (via GitHub)" <gi...@apache.org>.
mkitti commented on PR #99:
URL: https://github.com/apache/ant-ivy/pull/99#issuecomment-2755654700
I'm perfectly fine being part of the contributor's list. Thank you for getting this merged.
I'm checking my fork to see if there is any other code in the diff. I believe there might be a lingering issue regarding OS specific profile activations. Once I figure out why I wrote this code, I will create a JIRA issue.
https://github.com/mkitti/ant-ivy/compare/mkitti-maven-classifier-clean...mkitti:ant-ivy:janelia_release_2_5_3#diff-7c05a4255accccf66e450821bb43bc5c9ddf05407293d3079ecab5f6a07e3847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org