[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7572: tools: Fix various error in Windows native build

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #7572:
URL: https://github.com/apache/nuttx/pull/7572#discussion_r1033693887


##########
tools/Config.mk:
##########
@@ -393,11 +393,18 @@ endef
 # ARCHIVE - Same as above, but ensure the archive is
 # created from scratch
 
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+define ARCHIVE
+	$(Q) $(RM) $1
+	$(Q) $(AR) $1 $(2)
+endef
+else
 define ARCHIVE
 	@echo "AR (create): ${shell basename $(1)} $(2)"

Review Comment:
   BTW, why line 389 doesn't hit the similar issue on Windows?



##########
tools/Config.mk:
##########
@@ -393,11 +393,18 @@ endef
 # ARCHIVE - Same as above, but ensure the archive is
 # created from scratch
 
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+define ARCHIVE
+	$(Q) $(RM) $1
+	$(Q) $(AR) $1 $(2)
+endef
+else
 define ARCHIVE
 	@echo "AR (create): ${shell basename $(1)} $(2)"

Review Comment:
   can we change to:
   @echo "AR(create): $(1) $(2)"
   to avoid the duplication.



##########
libs/libc/Makefile:
##########
@@ -114,8 +114,8 @@ endif
 
 BINDIR ?= bin
 
-AOBJS = $(patsubst %.S, $(BINDIR)$(DELIM)%$(OBJEXT), $(ASRCS))
-COBJS = $(patsubst %.c, $(BINDIR)$(DELIM)%$(OBJEXT), $(CSRCS))
+AOBJS = $(patsubst %.S, $(BINDIR)$(DELIM)$(DELIM)%$(OBJEXT), $(ASRCS))

Review Comment:
   it's strange that two $(DELIM) are required here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org