You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/05/19 23:59:55 UTC
[jira] Created: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
JobClient should not have a static configuration for cli parsing
----------------------------------------------------------------
Key: HADOOP-3417
URL: https://issues.apache.org/jira/browse/HADOOP-3417
Project: Hadoop Core
Issue Type: Bug
Reporter: Owen O'Malley
HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3417:
--------------------------------------------
Release Note:
Removed the public class org.apache.hadoop.mapred.JobShell.
Command line options -libjars, -files and -archives are moved GenericCommands. Thus applications have to implement org.apache.hadoop.util.Tool to use the options.
Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed])
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3417:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Amareshwari!
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3417:
--------------------------------------------
Attachment: patch-3417.txt
Here is a patch doing the following:
1. Removes the static configuration variable, commandLineConfig from JobClient.
2. Moves the cli parsing from JobShell to GenericOptionsParser. Thus removes the class org.apache.hadoop.mapred.JobShell .
3. Refactors TestJobShell as TestCommandLineJobSubmission, which tests the command line options -files, -libjars
4. testshell.ExternalMapReduce class is modified to implement org.apache.hadoop.util.Tool, sothat it can be run from ToolRunner.
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3417:
--------------------------------------------
Status: Patch Available (was: Open)
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600956#action_12600956 ]
Mahadev konar commented on HADOOP-3417:
---------------------------------------
+1 looks good.
Only one thing -- the test (which is my fault) creates a file files_tmp in the workspace of hadoop (the top level dir of hadoop) -- there is a bug filed to fix that. If you can fix that as a part of this patch, that would be great -- or else i will fix it.
http://issues.apache.org/jira/browse/HADOOP-3240 is the issue for this problem.
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601545#action_12601545 ]
Hadoop QA commented on HADOOP-3417:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382910/patch-3417.txt
against trunk revision 661918.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2533/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2533/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2533/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2533/console
This message is automatically generated.
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602494#action_12602494 ]
Mahadev konar commented on HADOOP-3417:
---------------------------------------
the commit missed to svn add a new file (a test case) in the patch. That is TestCommandLineJobbSubmission.java.
Can you fix it devaraj?
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3417:
--------------------------------------------
Status: Patch Available (was: Open)
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3417:
--------------------------------------------
Status: Open (was: Patch Available)
trying to run hudson again
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3417:
--------------------------------------------
Release Note:
Removed the public class org.apache.hadoop.mapred.JobShell.
Command line options -libjars, -files and -archives are moved to GenericCommands. Thus applications have to implement org.apache.hadoop.util.Tool to use the options.
was:
Removed the public class org.apache.hadoop.mapred.JobShell.
Command line options -libjars, -files and -archives are moved GenericCommands. Thus applications have to implement org.apache.hadoop.util.Tool to use the options.
Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed, Incompatible change])
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
> Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3417) JobClient should not have a static
configuration for cli parsing
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3417:
--------------------------------------------
Component/s: mapred
Affects Version/s: 0.17.0
Fix Version/s: 0.18.0
Assignee: Amareshwari Sriramadasu
> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
> Key: HADOOP-3417
> URL: https://issues.apache.org/jira/browse/HADOOP-3417
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.18.0
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that prevents it from being used by multiple threads. Furthermore, the cli processing that HADOOP-1622 added should be in the GenericOptionParser instead of JobShell so that all of the implementations of Tool can use them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.