You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/11/12 22:50:53 UTC

[GitHub] [geode] echobravopapa commented on a change in pull request #5744: GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException

echobravopapa commented on a change in pull request #5744:
URL: https://github.com/apache/geode/pull/5744#discussion_r522459797



##########
File path: geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##########
@@ -137,6 +137,18 @@ public void startedLocatorHasLocator() throws IOException {
     assertThat(InternalLocator.hasLocator()).isTrue();
   }
 
+  @Test

Review comment:
       I'm not saying this test is invalid, but it doesn't validate the fix below in `InternalLocator` i.e. if one comments out that code the test still passes...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org