[GitHub] [superset] kgabryje commented on a change in pull request #18947: fix(plugin-chart-echarts): make to allow the custome of x & y axis title margin i…

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #18947:
URL: https://github.com/apache/superset/pull/18947#discussion_r821011414



##########
File path: superset-frontend/plugins/plugin-chart-echarts/src/utils/helper.ts
##########
@@ -0,0 +1,4 @@
+export const convertInteger = (value: string | number) => {

Review comment:
       1. You need to add a license to make this PR pass the CI (just copy paste the comment from top of any js file)
   2. Can we we use more descriptive file names? Maybe the same as the function name




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org