You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Viraj Jasani (JIRA)" <ji...@apache.org> on 2019/07/14 15:02:00 UTC

[jira] [Comment Edited] (HBASE-22132) Backport HBASE-22115 intent to branch-1

    [ https://issues.apache.org/jira/browse/HBASE-22132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884618#comment-16884618 ] 

Viraj Jasani edited comment on HBASE-22132 at 7/14/19 3:01 PM:
---------------------------------------------------------------

branch-1 has majority of the tracescope covered with try-with-resources or getting closed manually e.g. CallRunner: [https://github.com/apache/hbase/blame/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java#L138]

However, we can incorporate try-with-resources change for tracescope in MemStoreFlusher.reclaimMemStoreMemory() as part of this JIRA. [~apurtell] Can I take this up if the proposed change looks good to you?


was (Author: vjasani):
branch-1 has majority of the tracescope covered with try-with-resources or getting closed manually e.g. CallRunner: [https://github.com/apache/hbase/blob/70841445127608d6ed71ed7eab20859b3a9953b6/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java#L152]

However, we can incorporate try-with-resources change for tracescope in MemStoreFlusher.reclaimMemStoreMemory() as part of this JIRA. [~apurtell] Can I take this up if the proposed change looks good to you?

> Backport HBASE-22115 intent to branch-1
> ---------------------------------------
>
>                 Key: HBASE-22132
>                 URL: https://issues.apache.org/jira/browse/HBASE-22132
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 1.5.0
>            Reporter: Andrew Purtell
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Check the exposure of branch-1 code to the problems described on HBASE-22115 and apply the fix approach there.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)