You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2023/10/16 15:28:18 UTC

[PR] Add `check_interval` and `max_attempts` as parameter of `DynamoDBToS3Operator` [airflow]

vincbeck opened a new pull request, #34972:
URL: https://github.com/apache/airflow/pull/34972

   Add `check_interval` and `max_attempts` as parameter of `DynamoDBToS3Operator` to override default values if needed.
   
   I modified the system test `example_dynamodb_to_s3.py` as well to increase `max_attempts` because sometimes the waiter times out while the export is still in progress. That's the reason for the last failure in this system test.
   
   ```
   
   
   Traceback (most recent call last):
   --
   51 | File "/opt/airflow/airflow/models/taskinstance.py", line 432, in _execute_task
   52 | result = execute_callable(context=context, **execute_callable_kwargs)
   53 | File "/opt/airflow/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py", line 143, in execute
   54 | self._export_table_to_point_in_time()
   55 | File "/opt/airflow/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py", line 167, in _export_table_to_point_in_time
   56 | waiter.wait(ExportArn=export_arn)
   57 | File "/usr/local/lib/python3.8/site-packages/botocore/waiter.py", line 55, in wait
   58 | Waiter.wait(self, **kwargs)
   59 | File "/usr/local/lib/python3.8/site-packages/botocore/waiter.py", line 388, in wait
   60 | raise WaiterError(
   61 | botocore.exceptions.WaiterError: Waiter export_table failed: Max attempts exceeded. Previously accepted state: For expression "ExportDescription.ExportStatus" we matched expected path: "IN_PROGRESS"
   ```
   
   cc @ferruzzi @o-nikolas 
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `check_interval` and `max_attempts` as parameter of `DynamoDBToS3Operator` [airflow]

Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi merged PR #34972:
URL: https://github.com/apache/airflow/pull/34972


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org