[GitHub] [samza] cameronlee314 opened a new pull request #1594: SAMZA-2685: fall back to ClusterBasedJobCoordinator when job.coordinator.factory is the empty string for cluster-based deployments

[GitBox <gi...@apache.org>]

cameronlee314 opened a new pull request #1594:
URL: https://github.com/apache/samza/pull/1594


   Issues: The first PR for SAMZA-2685 (PR #1529) only used `ClusterBasedJobCoordinator` when `job.coordinator.factory` was not specified. Some apps may prefer to use the empty string instead to indicate using the default `ClusterBasedJobCoordinator`.
   
   Changes: `getOptionalJobCoordinatorFactoryClassName` now returns "empty" when the value of `job.coordinator.factory` is the empty string.
   
   Tests: Added unit test
   
   API/usage changes: Using the empty string as the value for `job.coordinator.factory` when running in a cluster-based system (e.g. YARN) results in using `ClusterBasedJobCoordinator` instead of trying to load a class with the name of an empty string (which would fail).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] Zhangyx39 commented on pull request #1594: SAMZA-2685: fall back to ClusterBasedJobCoordinator when job.coordinator.factory is the empty string for cluster-based deployments

[GitBox <gi...@apache.org>]

Zhangyx39 commented on pull request #1594:
URL: https://github.com/apache/samza/pull/1594#issuecomment-1086238078


   LGTM. Thanks for the quick change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org