You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Jirsa (JIRA)" <ji...@apache.org> on 2017/02/09 23:21:41 UTC

[jira] [Comment Edited] (CASSANDRA-13205) Hint related logging should include the IP address of the destination in addition to host ID

    [ https://issues.apache.org/jira/browse/CASSANDRA-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860375#comment-15860375 ] 

Jeff Jirsa edited comment on CASSANDRA-13205 at 2/9/17 11:20 PM:
-----------------------------------------------------------------

Thanks [~bdeggleston]

{quote}
There are also a couple of log messages here and here in HintsReader that refer to hostId, and not endpoint
{quote}

Done.

{quote}
there's a warning in the 3.0 version of the HintVerbHandler that intends to log the table id here but does not
{quote}

In [3.11|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/hints/HintVerbHandler.java#L71], that warning no longer includes the table ID, so I've made the 3.0 version match that (removed the empty table ID, but added the endpoint address).



was (Author: jjirsa):
Thanks [~bdeggleston]

{quote}
There are also a couple of log messages here and here in HintsReader that refer to hostId, and not endpoint
{quote}

Done.

{quote}
there's a warning in the 3.0 version of the HintVerbHandler that intends to log the table id here but does not
{quote}

In 3.11, that warning no longer includes the table ID, so I've made the 3.0 version match that (removed the empty table ID, but added the endpoint address).


> Hint related logging should include the IP address of the destination in addition to host ID
> --------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13205
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13205
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>            Priority: Trivial
>             Fix For: 3.0.x
>
>
> After the hint rewrite in 3.0, many of the hint related logs now use hostId UUIDs rather than endpoint addresses. This complicates debugging unnecessarily. We should include both.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)