You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Falk.Tristram@cae.de (JIRA)" <ji...@apache.org> on 2012/05/04 14:34:48 UTC

[jira] [Created] (AVRO-1077) Missing 'inline' for union set function

Falk.Tristram@cae.de created AVRO-1077:
------------------------------------------

             Summary: Missing 'inline' for union set function
                 Key: AVRO-1077
                 URL: https://issues.apache.org/jira/browse/AVRO-1077
             Project: Avro
          Issue Type: Bug
          Components: c++
    Affects Versions: 1.6.3, 1.7.0
         Environment: Linux, gcc 4.6.2
            Reporter: Falk.Tristram@cae.de


The generated C++ set-functions for unions lack the inline keyword. Although its present in the corresponding get-functions. In our project this issue lead to linker-problems (multiple definitions).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-1077) Missing 'inline' for union set function

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-1077:
--------------------------------------

    Attachment: AVRO-1077.patch
    
> Missing 'inline' for union set function
> ---------------------------------------
>
>                 Key: AVRO-1077
>                 URL: https://issues.apache.org/jira/browse/AVRO-1077
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.6.3, 1.7.0
>         Environment: Linux, gcc 4.6.2
>            Reporter: Falk.Tristram@cae.de
>         Attachments: AVRO-1077.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The generated C++ set-functions for unions lack the inline keyword. Although its present in the corresponding get-functions. In our project this issue lead to linker-problems (multiple definitions).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-1077) Missing 'inline' for union set function

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-1077:
--------------------------------------

    Assignee: Thiruvalluvan M. G.
      Status: Patch Available  (was: Open)
    
> Missing 'inline' for union set function
> ---------------------------------------
>
>                 Key: AVRO-1077
>                 URL: https://issues.apache.org/jira/browse/AVRO-1077
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.6.3, 1.7.0
>         Environment: Linux, gcc 4.6.2
>            Reporter: Falk.Tristram@cae.de
>            Assignee: Thiruvalluvan M. G.
>         Attachments: AVRO-1077.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The generated C++ set-functions for unions lack the inline keyword. Although its present in the corresponding get-functions. In our project this issue lead to linker-problems (multiple definitions).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (AVRO-1077) Missing 'inline' for union set function

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274450#comment-13274450 ] 

Thiruvalluvan M. G. commented on AVRO-1077:
-------------------------------------------

Verified that this patch works with the following:
- Ubuntu 12.04
- Cygwin on Windows 7
- Windows (Visual Studio Expression 2010)
                
> Missing 'inline' for union set function
> ---------------------------------------
>
>                 Key: AVRO-1077
>                 URL: https://issues.apache.org/jira/browse/AVRO-1077
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.6.3, 1.7.0
>         Environment: Linux, gcc 4.6.2
>            Reporter: Falk.Tristram@cae.de
>            Assignee: Thiruvalluvan M. G.
>         Attachments: AVRO-1077.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The generated C++ set-functions for unions lack the inline keyword. Although its present in the corresponding get-functions. In our project this issue lead to linker-problems (multiple definitions).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-1077) Missing 'inline' for union set function

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-1077:
--------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed revision 1339049.

Thank you Falk Tristram for catching this.
                
> Missing 'inline' for union set function
> ---------------------------------------
>
>                 Key: AVRO-1077
>                 URL: https://issues.apache.org/jira/browse/AVRO-1077
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.6.3, 1.7.0
>         Environment: Linux, gcc 4.6.2
>            Reporter: Falk.Tristram@cae.de
>            Assignee: Thiruvalluvan M. G.
>         Attachments: AVRO-1077.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The generated C++ set-functions for unions lack the inline keyword. Although its present in the corresponding get-functions. In our project this issue lead to linker-problems (multiple definitions).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira