You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2011/08/03 00:26:39 UTC

Re: Review Request: Create a separate option for Hive variable substitution

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1204/#review1273
-----------------------------------------------------------


This patch doesn't appear to address most of the issues described in HIVE-2020, which covers adding a separate namespace for variables that is distinct from hiveconf and environment/system properties. This patch also needs a testcase.


cli/src/java/org/apache/hadoop/hive/cli/DefaultPreprocessor.java
<https://reviews.apache.org/r/1204/#comment2906>

    Please extend/modify/use the code in org.apache.hadoop.hive.ql.parse.VariableSubstitution instead of adding this class.



cli/src/java/org/apache/hadoop/hive/cli/OptionsProcessor.java
<https://reviews.apache.org/r/1204/#comment2905>

    I think these two option definitions can be combined, e.g:
    
    .withArgName("key=value")
    .withLongOpt("define")
    .create("d");


- Carl


On 2011-07-27 21:07:40, Vaibhav Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1204/
> -----------------------------------------------------------
> 
> (Updated 2011-07-27 21:07:40)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Create a separate option for Hive variable
> 
> 
> This addresses bug HIVE-2020.
>     https://issues.apache.org/jira/browse/HIVE-2020
> 
> 
> Diffs
> -----
> 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 9fa7bc6 
>   cli/src/java/org/apache/hadoop/hive/cli/DefaultPreprocessor.java PRE-CREATION 
>   cli/src/java/org/apache/hadoop/hive/cli/KeyValue.java PRE-CREATION 
>   cli/src/java/org/apache/hadoop/hive/cli/OptionsProcessor.java 90084ed 
>   cli/src/java/org/apache/hadoop/hive/cli/Preprocessor.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1204/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav
> 
>