You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Scott Chen (JIRA)" <ji...@apache.org> on 2011/02/03 23:10:29 UTC
[jira] Created: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Add static factory methods in GaloisField
-----------------------------------------
Key: MAPREDUCE-2302
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
Project: Hadoop Map/Reduce
Issue Type: Improvement
Components: contrib/raid
Reporter: Scott Chen
Assignee: Scott Chen
GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Status: Patch Available (was: Open)
Updated the patch to address Nicholas's comment.
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.3.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001130#comment-13001130 ]
Tsz Wo (Nicholas), SZE commented on MAPREDUCE-2302:
---------------------------------------------------
{code}
+ int key = ((fieldSize << 16) & 0xFF00) + (primitivePolynomial & 0xFF);
{code}
Since the shift is 16, should the masks be 0xFFFF0000 and 0xFFFF?
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thank you very much for the review, Nicholas :)
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.3.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Status: Patch Available (was: In Progress)
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001241#comment-13001241 ]
Tsz Wo (Nicholas), SZE commented on MAPREDUCE-2302:
---------------------------------------------------
+1 patch looks good.
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.3.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005961#comment-13005961 ]
Hudson commented on MAPREDUCE-2302:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #631 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/631/])
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.3.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Status: Patch Available (was: In Progress)
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990376#comment-12990376 ]
Scott Chen commented on MAPREDUCE-2302:
---------------------------------------
{code}
[exec] BUILD SUCCESSFUL
[exec] Total time: 2 minutes 16 seconds
[exec]
[exec]
[exec]
[exec]
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
[exec]
[exec]
[exec]
[exec]
[exec] ======================================================================
[exec] ======================================================================
[exec] Finished build.
[exec] ======================================================================
[exec] ======================================================================
{code}
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Attachment: MAPREDUCE-2302.2.txt
Addressed some offline comments from Ram
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Status: Open (was: Patch Available)
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Attachment: MAPREDUCE-2302.txt
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Attachment: MAPREDUCE-2302.3.txt
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.3.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MAPREDUCE-2302 started by Scott Chen.
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016950#comment-13016950 ]
Hudson commented on MAPREDUCE-2302:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #643 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/])
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.3.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated MAPREDUCE-2302:
----------------------------------
Status: Open (was: Patch Available)
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MAPREDUCE-2302 started by Scott Chen.
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001226#comment-13001226 ]
Scott Chen commented on MAPREDUCE-2302:
---------------------------------------
Tsz Wo: Good catch. Thanks. I will update the patch.
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2302) Add static factory methods in
GaloisField
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001308#comment-13001308 ]
Hadoop QA commented on MAPREDUCE-2302:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12472379/MAPREDUCE-2302.3.txt
against trunk revision 1075670.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/110//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/110//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/110//console
This message is automatically generated.
> Add static factory methods in GaloisField
> -----------------------------------------
>
> Key: MAPREDUCE-2302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.3.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation of the multiplication and division tables.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira