You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by Christofer Dutz <ch...@c-ware.de> on 2019/09/26 12:10:02 UTC

[VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Directly when reviewing the RC1 I noticed the RELEASE_NOTES referenced a
SNAPSHOT version, so I immediately did a RC2

Apache PLC4X Build-Tools Code-Generation 1.0.0 has been staged under [2]
and it’s time to vote on accepting it for release.

All Maven artifacts are available under [1]. Voting will be open for 72hr.

A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.

Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
Release tag: release/code-generation/1.0.0
Hash for the release tag: 5eb960d1531619d78798fc220aa16fe61cff083f<https://gitbox.apache.org/repos/asf?p=plc4x-build-tools.git;a=commit;h=5eb960d1531619d78798fc220aa16fe61cff083f>

Per [3] "Before voting +1 PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases."

You can achieve the above by following [4].

[ ]  +1 accept (indicate what you validated - e.g. performed the non-RM items in [4])
[ ]  -1 reject (explanation required)


[1] https://repository.apache.org/content/repositories/orgapacheplc4x-1011
[2] https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.0.0/rc2/
[3] https://www.apache.org/dev/release.html#approving-a-release
[4] https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release


Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Posted by Julian Feinauer <j....@pragmaticminds.de>.
That's a good point from Justin... We really hope to be low with releases.
Would it be too hard to prepare another RC Chris?

J
________________________________
From: Justin Mclean <ju...@classsoftware.com>
Sent: Friday, September 27, 2019 11:47:56 AM
To: dev@plc4x.apache.org <de...@plc4x.apache.org>
Subject: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Hi,

> I copied the LICENSE from plc4x into the plc4x-build-tools and didn't notice the end at first.

I gather this is not going to be released that often(/). If so it might be best to fix this so the LICENSE is correct.

Thanks,
Justin


Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> I copied the LICENSE from plc4x into the plc4x-build-tools and didn't notice the end at first.

I gather this is not going to be released that often(/). If so it might be best to fix this so the LICENSE is correct.

Thanks,
Justin


Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Posted by Christofer Dutz <ch...@c-ware.de>.
I copied the LICENSE from plc4x into the plc4x-build-tools and didn't notice the end at first.
And I mentioned that in my vote email.

Chris

Am 27.09.19, 08:44 schrieb "Justin Mclean" <ju...@classsoftware.com>:

    Hi,
    
    > But as far as I know there's no Netty in the plugin…
    
    Then why is it mentioned in LICENSE?
    
    Thanks,
    Justin


Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> But as far as I know there's no Netty in the plugin…

Then why is it mentioned in LICENSE?

Thanks,
Justin

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Posted by Christofer Dutz <ch...@c-ware.de>.
Actually the only non apache artifact it uses is junit.

Holen Sie sich Outlook für Android<https://aka.ms/ghei36>

________________________________
From: Christofer Dutz
Sent: Friday, September 27, 2019 7:28:55 AM
To: dev@plc4x.apache.org <de...@plc4x.apache.org>
Subject: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

But as far as I know there's no Netty in the plugin...

Holen Sie sich Outlook für Android<https://aka.ms/ghei36>

________________________________
From: Justin Mclean <ju...@classsoftware.com>
Sent: Thursday, September 26, 2019 11:49:03 PM
To: dev@plc4x.apache.org <de...@plc4x.apache.org>
Subject: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Hi,

-1 (binding) as NOTICE file is missing information

I checked:
- signatures and hashes fine
- LICENSE is OK
- NOTICE need some more work(see below)
- No unexpected binary files
- All source files have ASF headers
- Can compile from source

Netty has a NOTICE file [1] so relevant portions of that need to be copied to our NOTICE file. [2] I would assume it would the top few lines but not 100%?

Thanks,
Justin

1. https://github.com/netty/netty/blob/4.1/NOTICE.txt
2. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Posted by Christofer Dutz <ch...@c-ware.de>.
But as far as I know there's no Netty in the plugin...

Holen Sie sich Outlook für Android<https://aka.ms/ghei36>

________________________________
From: Justin Mclean <ju...@classsoftware.com>
Sent: Thursday, September 26, 2019 11:49:03 PM
To: dev@plc4x.apache.org <de...@plc4x.apache.org>
Subject: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Hi,

-1 (binding) as NOTICE file is missing information

I checked:
- signatures and hashes fine
- LICENSE is OK
- NOTICE need some more work(see below)
- No unexpected binary files
- All source files have ASF headers
- Can compile from source

Netty has a NOTICE file [1] so relevant portions of that need to be copied to our NOTICE file. [2] I would assume it would the top few lines but not 100%?

Thanks,
Justin

1. https://github.com/netty/netty/blob/4.1/NOTICE.txt
2. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

-1 (binding) as NOTICE file is missing information

I checked:
- signatures and hashes fine
- LICENSE is OK
- NOTICE need some more work(see below)
- No unexpected binary files
- All source files have ASF headers
- Can compile from source

Netty has a NOTICE file [1] so relevant portions of that need to be copied to our NOTICE file. [2] I would assume it would the top few lines but not 100%?

Thanks,
Justin

1. https://github.com/netty/netty/blob/4.1/NOTICE.txt
2. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

Posted by Christofer Dutz <ch...@c-ware.de>.
+1 (binding)

Chris

Here what I checked:

- SHA512 Hashes are valid
- PGP signatures match
- signed by apache email address
- zip unpacks
- Content of LICENSE, NOTICE, README, RELEASE_NOTES is correct (Except that the LICENSE file contains a list of files, that are not contained in the archive)
- README and RELEASE_NOTES matches the files in the archive
- Projects builds correctly according to the README
- Manually executed RAT: no findings (java -jar ../../../Devtools/Apache/RAT/apache-rat-0.13/apache-rat-0.13.jar -d .)
- No SNAPSHOTs referenced
- No failed tests (Well ... no tests, so none fail ;-) )


Minor: 
The Apache License file references files that are not contained in the ZIP


Am 26.09.19, 14:10 schrieb "Christofer Dutz" <ch...@c-ware.de>:

    Directly when reviewing the RC1 I noticed the RELEASE_NOTES referenced a
    SNAPSHOT version, so I immediately did a RC2
    
    Apache PLC4X Build-Tools Code-Generation 1.0.0 has been staged under [2]
    and it’s time to vote on accepting it for release.
    
    All Maven artifacts are available under [1]. Voting will be open for 72hr.
    
    A minimum of 3 binding +1 votes and more binding +1 than binding -1
    are required to pass.
    
    Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
    Release tag: release/code-generation/1.0.0
    Hash for the release tag: 5eb960d1531619d78798fc220aa16fe61cff083f<https://gitbox.apache.org/repos/asf?p=plc4x-build-tools.git;a=commit;h=5eb960d1531619d78798fc220aa16fe61cff083f>
    
    Per [3] "Before voting +1 PMC members are required to download
    the signed source code package, compile it as provided, and test
    the resulting executable on their own platform, along with also
    verifying that the package meets the requirements of the ASF policy
    on releases."
    
    You can achieve the above by following [4].
    
    [ ]  +1 accept (indicate what you validated - e.g. performed the non-RM items in [4])
    [ ]  -1 reject (explanation required)
    
    
    [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1011
    [2] https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.0.0/rc2/
    [3] https://www.apache.org/dev/release.html#approving-a-release
    [4] https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release