[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19654: [WIP] Migrate to use ECR as docker cache instead of dockerhub

[GitBox <gi...@apache.org>]

josephevans commented on a change in pull request #19654:
URL: https://github.com/apache/incubator-mxnet/pull/19654#discussion_r540694078



##########
File path: ci/build.py
##########
@@ -117,6 +123,8 @@ def run_cmd():
     image_id = _get_local_image_id(docker_tag=tag)
     if not image_id:
         raise FileNotFoundError('Unable to find docker image id matching with {}'.format(tag))
+    # now that we've built the container, push it to our docker cache
+    push_docker_cache(registry, tag, image_id)

Review comment:
       Good point. Right now, it will fail with just a warning and continue on, but maybe we should only attempt pushing the image if an environment variable (such as DOCKER_ECR_REGISTRY) is set.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org