You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Zsolt Kúti (JIRA)" <ji...@apache.org> on 2009/09/27 19:09:16 UTC

[jira] Created: (RIVER-321) Process of an interrupted test can be left over

Process of an interrupted test can be left over
-----------------------------------------------

                 Key: RIVER-321
                 URL: https://issues.apache.org/jira/browse/RIVER-321
             Project: River
          Issue Type: Bug
          Components: other
            Reporter: Zsolt Kúti
            Priority: Minor


In MasterHarness.runTestOtherVM() a test is launched in a separate VM. In the InterruptedException catching a kill of the process is attempted probably with a Solaris specific path (/usr/bin). At least on BSD systems (like mine, FreeBSD) it is under /bin.
Perhaps improvement issue type would better fit?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (RIVER-321) Process of an interrupted test can be left over

Posted by "Dan Rollo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RIVER-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761076#action_12761076 ] 

Dan Rollo commented on RIVER-321:
---------------------------------

I we ever find a way to kill a process in a cross-platform way, I will steal that code right away! ;) I've been on the lookout for a way to kill a process for use in CruiseControl for a long time. I've thought about using jna (https://jna.dev.java.net/) to call native kill methods. I also hoped to find something like this in a "commons" library, but have had no luck so far.

> Process of an interrupted test can be left over
> -----------------------------------------------
>
>                 Key: RIVER-321
>                 URL: https://issues.apache.org/jira/browse/RIVER-321
>             Project: River
>          Issue Type: Bug
>          Components: other
>            Reporter: Zsolt Kúti
>            Priority: Minor
>
> In MasterHarness.runTestOtherVM() a test is launched in a separate VM. In the InterruptedException catching a kill of the process is attempted probably with a Solaris specific path (/usr/bin). At least on BSD systems (like mine, FreeBSD) it is under /bin.
> Perhaps improvement issue type would better fit?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (RIVER-321) Process of an interrupted test can be left over

Posted by "Zsolt Kúti (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RIVER-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760364#action_12760364 ] 

Zsolt Kúti commented on RIVER-321:
----------------------------------

Since the problem to solve is how to kill a process on an arbritrary OS and bring this info to the right place, it really is. As to the first part, one option is applying an OS dependant conditional logic for the command. On unix systems this logic might be substituted with a logic that probes possible pathes. The best would be to be able to safely rely on the kill command being on the path. Perhaps a sanity check before starting tests is in order. The second part could perhaps be solved by using a system property that has the command as value or an appropriate class (QARunner?) can directly contain the logic and pass down the info.

> Process of an interrupted test can be left over
> -----------------------------------------------
>
>                 Key: RIVER-321
>                 URL: https://issues.apache.org/jira/browse/RIVER-321
>             Project: River
>          Issue Type: Bug
>          Components: other
>            Reporter: Zsolt Kúti
>            Priority: Minor
>
> In MasterHarness.runTestOtherVM() a test is launched in a separate VM. In the InterruptedException catching a kill of the process is attempted probably with a Solaris specific path (/usr/bin). At least on BSD systems (like mine, FreeBSD) it is under /bin.
> Perhaps improvement issue type would better fit?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (RIVER-321) Process of an interrupted test can be left over

Posted by "Jonathan Costers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RIVER-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760125#action_12760125 ] 

Jonathan Costers commented on RIVER-321:
----------------------------------------

Interesting find. 
It is of no surprise since originally this code only ran at Sun internally. They had no need for a cross platform solution at the time.
I would have to look into it deeper, but I think solving this is a challenge.

> Process of an interrupted test can be left over
> -----------------------------------------------
>
>                 Key: RIVER-321
>                 URL: https://issues.apache.org/jira/browse/RIVER-321
>             Project: River
>          Issue Type: Bug
>          Components: other
>            Reporter: Zsolt Kúti
>            Priority: Minor
>
> In MasterHarness.runTestOtherVM() a test is launched in a separate VM. In the InterruptedException catching a kill of the process is attempted probably with a Solaris specific path (/usr/bin). At least on BSD systems (like mine, FreeBSD) it is under /bin.
> Perhaps improvement issue type would better fit?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.