[GitHub] [pulsar] lhotari opened a new pull request, #19392: [fix][client] Fix async completion in ConsumerImpl#processPossibleToDLQ

["lhotari (via GitHub)" <gi...@apache.org>]

lhotari opened a new pull request, #19392:
URL: https://github.com/apache/pulsar/pull/19392

   ### Motivation
   
   - the possible failure of acknowledging the message isn't handled in ConsumerImpl#processPossibleToDLQ
   
   The `exceptionally` handler in the code below this particular location doesn't get executed, since it's in a different call chain than the `acknowledgeAsync` call. Perhaps that was the author's expectation that the failure would be handled by the `exceptionally` handler.
   
   ### Modifications
   
   - complete the future with `false` when there are failures.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #19392: [fix][client] Fix async completion in ConsumerImpl#processPossibleToDLQ

["lhotari (via GitHub)" <gi...@apache.org>]

lhotari merged PR #19392:
URL: https://github.com/apache/pulsar/pull/19392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org