You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jablko <gi...@git.apache.org> on 2014/03/14 19:03:12 UTC
[GitHub] trafficserver pull request: TS-2553 metalink: Fix crash if INKVCon...
GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/63
TS-2553 metalink: Fix crash if INKVConnInternal::do_io_close() gets called after a message is already complete
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver TS-2553
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit e5c4969fe2ebb96ec8cb595ce0951d1c86ca6e04
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T18:15:35Z
metalink: strcasecmp(3) says #include <strings.h>
commit e9c7ff303c9e154f1dde12f139b165c244296e32
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T18:18:17Z
metalink: C style casts for consistency
commit ca364848ad76aabc8f3aca16ef9bc755c9e9dba3
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T18:27:18Z
metalink: Give some variables better names
commit e97fe577271a697627c816ed71cdc3b9c95f112e
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T18:28:58Z
metalink: Add missing destroy
commit e233fd1c6f6ebc13b8850a8a071aa9b78e7a8cd6
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T18:57:17Z
metalink: Reuse TSCacheWrite() vs. TSTransformCreate() continuation
commit 5a965b1a89f2763902119f9a89e8488f3e88e713
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T19:56:53Z
metalink: Handle the end of the input independently from the TS_EVENT_VCONN_WRITE_COMPLETE event from downstream
commit 56b65e37b111005b204e4112dd3cd6df7361cbb7
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T20:07:53Z
metalink: Plug memory leaks reported by Valgrind
commit fd9a0153284978d881f0bb190e8dd95216be90e0
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T20:19:44Z
metalink: Drop redundant TSUrlStringGet()
commit 51c0eca079abf6361e9dbb6cd777996737166032
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T20:43:10Z
metalink: Simpler to drop http.HTTPClient where not needed and minor edits
commit 45393e797d69606dcb82db64acb71d61aa55a947
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T20:59:01Z
TS-2553 metalink: Fix crash if INKVConnInternal::do_io_close() gets called after a message is already complete
commit 850380ac3348288e81742a50ed59998c76d8275e
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T21:02:19Z
metalink: Send our own TS_EVENT_VCONN_WRITE_COMPLETE event upstream when the input is complete otherwise HttpSM::update_stats() won't get called and the transaction won't get logged. (If there are upstream transformations they won't get a chance to clean up otherwise!)
commit c620b474b768b779ebf4e22746a2f5d00da4eb7a
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-03-13T21:48:28Z
metalink: Improve comments and whitespace
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2553 metalink: Fix crash if INKVCon...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/63#issuecomment-38756086
jablko, can you please make a new branch from master for this pull request? I think that we should also have a new Jira ticket, since TS-2553 is long closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2553 metalink: Fix crash if INKVCon...
Posted by jablko <gi...@git.apache.org>.
Github user jablko commented on the pull request:
https://github.com/apache/trafficserver/pull/63#issuecomment-38999285
Pulled as ad6806e, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2553 metalink: Fix crash if INKVCon...
Posted by Humbedooh <gi...@git.apache.org>.
Github user Humbedooh closed the pull request at:
https://github.com/apache/trafficserver/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2553 metalink: Fix crash if INKVCon...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/63#issuecomment-38756233
Also, do you have instructions on how to reproduce this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2553 metalink: Fix crash if INKVCon...
Posted by jablko <gi...@git.apache.org>.
Github user jablko commented on the pull request:
https://github.com/apache/trafficserver/pull/63#issuecomment-38952957
The metalink/test/pipeliningDisconnect script in commit 45393e reproduces the crash two out of three times on my system, but if it's a race condition it might manifest with different frequency on different systems? Unfortunately I haven't figured out yet how to exercise it deterministically from "outside" Traffic Server (by using just a combination of requests/responses and config settings). Any advice on how to expose it more predictably?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---