You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/06/16 11:06:29 UTC
[GitHub] [datasketches-cpp] FluorineDog opened a new issue, #287: static analyzer detects a possible bug
FluorineDog opened a new issue, #287:
URL: https://github.com/apache/datasketches-cpp/issues/287
Recently, we run static analyzer on our project, and it reports the following problem:
https://github.com/apache/datasketches-cpp/blob/ce4d82c6807bbf0ed9b993d810a22320d53d0747/cpc/include/cpc_compressor_impl.hpp#L299-L300
L299 get `pseudo_phase`, which could be `16 + x`. But the `column_permutations_for_encoding` is a fixed 2-D array with dimension `[16][59]`, so it's a possible overflow.
If this is a false positive, maybe we should add a check like the following (found in the coresponding uncompress method) to make the static analyzer happy?
https://github.com/apache/datasketches-cpp/blob/ce4d82c6807bbf0ed9b993d810a22320d53d0747/cpc/include/cpc_compressor_impl.hpp#L336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov commented on issue #287: static analyzer detects a possible bug
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #287:
URL: https://github.com/apache/datasketches-cpp/issues/287#issuecomment-1157890355
Could you clarify what do you mean by the phrase "on our project" please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov commented on issue #287: static analyzer detects a possible bug
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #287:
URL: https://github.com/apache/datasketches-cpp/issues/287#issuecomment-1158132884
I looked at the code, and I believe that in this mode the pseudo phase must be within the range from 0 to 15. So I would agree with you that we could check that as you suggest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] FluorineDog commented on issue #287: static analyzer detects a possible bug
Posted by GitBox <gi...@apache.org>.
FluorineDog commented on issue #287:
URL: https://github.com/apache/datasketches-cpp/issues/287#issuecomment-1158509290
I mean my company's database project including this as a third-party lib. We are introduing static analyzer to improve quailty of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov closed issue #287: static analyzer detects a possible bug
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov closed issue #287: static analyzer detects a possible bug
URL: https://github.com/apache/datasketches-cpp/issues/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org