[GitHub] [flink] tillrohrmann edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

[GitBox <gi...@apache.org>]

tillrohrmann edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609711858
 
 
   Thanks for creating this PR @zentol.
   
   From a software engineering standpoint I agree with these changes. It makes sense to reduce duplication.
   
   From a workflow perspective I think it worsens the situation a bit (or at least it disrupts the existing workflow). Currently when debugging a test from within the IDE, I jump to the test file, which brings me to the correct module, and then I change the `log4j2-test.properties` file in the resources folder of the test folder. This is quite easy and straight forward. With this change, now everyone has to remember that the `logj42-test.properties` comes from `flink-test-utils-junit` which is a higher intrinsic burden and not that obvious when you are new to the project.
   
   Before doing any changes, I advise to start a discussion on dev about this topic outlining the benefits and drawbacks as well as the implications for the devs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services