You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "HolyLow (via GitHub)" <gi...@apache.org> on 2025/08/13 02:51:45 UTC

[PR] [CELEBORN-2098][CIP-14] Support Revive/Response in cppClient [celeborn]

HolyLow opened a new pull request, #3413:
URL: https://github.com/apache/celeborn/pull/3413

   ### What changes were proposed in this pull request?
   This PR supports Revive/ChangeLocationResponse messages in cppClient.
   
   ### Why are the changes needed?
   These messages are used when writing triggers revive operation.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Compilation and UTs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2098][CIP-14] Support Revive/Response in cppClient [celeborn]

Posted by "HolyLow (via GitHub)" <gi...@apache.org>.
HolyLow commented on PR #3413:
URL: https://github.com/apache/celeborn/pull/3413#issuecomment-3182010264

   @SteNicholas @FMX @RexXiong Could you kindly help review this PR? Thanks a lot.
   
   Any suggestion is welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2098][CIP-14] Support Revive/Response in cppClient [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3413:
URL: https://github.com/apache/celeborn/pull/3413#issuecomment-3193390651

   Merged to main(v0.7.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2098][CIP-14] Support Revive/Response in cppClient [celeborn]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3413:
URL: https://github.com/apache/celeborn/pull/3413#issuecomment-3182035538

   ## [Codecov](https://app.codecov.io/gh/apache/celeborn/pull/3413?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 63.77%. Comparing base ([`8ae9737`](https://app.codecov.io/gh/apache/celeborn/commit/8ae97376010c191293d3dd5ae5f39aba5692eb57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e9299c`](https://app.codecov.io/gh/apache/celeborn/commit/4e9299c08ea73ad50ee68b31692ae6e8da5d286e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 47 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #3413      +/-   ##
   ==========================================
   + Coverage   63.57%   63.77%   +0.21%     
   ==========================================
     Files         348      351       +3     
     Lines       21300    21522     +222     
     Branches     1879     1912      +33     
   ==========================================
   + Hits        13539    13724     +185     
   - Misses       6781     6801      +20     
   - Partials      980      997      +17     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celeborn/pull/3413?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2098][CIP-14] Support Revive/Response in cppClient [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3413: [CELEBORN-2098][CIP-14] Support Revive/Response in cppClient
URL: https://github.com/apache/celeborn/pull/3413


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org