You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/02 01:55:03 UTC
[GitHub] [incubator-shenyu] moremind opened a new pull request, #3474: [type:optimize] optimize netty http server parameters.
moremind opened a new pull request, #3474:
URL: https://github.com/apache/incubator-shenyu/pull/3474
// Describe your PR here; eg. Fixes #issueNo
optimize netty http server parameters.
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3474: [type:optimize] optimize netty http server parameters.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3474:
URL: https://github.com/apache/incubator-shenyu/pull/3474#issuecomment-1145679631
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3474?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3474](https://codecov.io/gh/apache/incubator-shenyu/pull/3474?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (961d81e) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/b771ff2e6446051245094d3f27b3e29fa4c4e5be?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b771ff2) will **decrease** coverage by `0.59%`.
> The diff coverage is `38.00%`.
```diff
@@ Coverage Diff @@
## master #3474 +/- ##
============================================
- Coverage 63.20% 62.60% -0.60%
+ Complexity 5530 5508 -22
============================================
Files 828 834 +6
Lines 23021 23134 +113
Branches 2073 2089 +16
============================================
- Hits 14551 14484 -67
- Misses 7141 7310 +169
- Partials 1329 1340 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...arter/netty/ShenyuNettyWebServerConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItZ2F0ZXdheS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwcmluZ2Jvb3Qvc3RhcnRlci9uZXR0eS9TaGVueXVOZXR0eVdlYlNlcnZlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `23.68% <14.70%> (-23.69%)` | :arrow_down: |
| [...ringboot/starter/netty/NettyChannelProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItZ2F0ZXdheS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwcmluZ2Jvb3Qvc3RhcnRlci9uZXR0eS9OZXR0eUNoYW5uZWxQcm9wZXJ0aWVzLmphdmE=) | `86.36% <81.81%> (-1.88%)` | :arrow_down: |
| [.../springboot/starter/netty/NettyHttpProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItZ2F0ZXdheS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwcmluZ2Jvb3Qvc3RhcnRlci9uZXR0eS9OZXR0eUh0dHBQcm9wZXJ0aWVzLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...plugin/logging/rocketmq/LoggingRocketMQPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvTG9nZ2luZ1JvY2tldE1RUGx1Z2luLmphdmE=) | `22.72% <0.00%> (-72.73%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...ogging/rocketmq/body/LoggingServerHttpRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvYm9keS9Mb2dnaW5nU2VydmVySHR0cFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `70.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `74.79% <0.00%> (-8.95%)` | :arrow_down: |
| [...shenyu/admin/service/impl/MetaDataServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL01ldGFEYXRhU2VydmljZUltcGwuamF2YQ==) | `86.66% <0.00%> (-7.24%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3474/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3474?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3474?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b771ff2...961d81e](https://codecov.io/gh/apache/incubator-shenyu/pull/3474?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] moremind commented on a diff in pull request #3474: [type:optimize] optimize netty http server parameters.
Posted by GitBox <gi...@apache.org>.
moremind commented on code in PR #3474:
URL: https://github.com/apache/incubator-shenyu/pull/3474#discussion_r890125660
##########
shenyu-bootstrap/src/main/resources/application.yml:
##########
@@ -71,11 +71,12 @@ management:
shenyu:
netty:
- tcp:
+ http:
Review Comment:
I have added document for this pr. please see https://github.com/apache/incubator-shenyu-website/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #3474: [type:optimize] optimize netty http server parameters.
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3474:
URL: https://github.com/apache/incubator-shenyu/pull/3474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #3474: [type:optimize] optimize netty http server parameters.
Posted by GitBox <gi...@apache.org>.
yu199195 commented on PR #3474:
URL: https://github.com/apache/incubator-shenyu/pull/3474#issuecomment-1144362037
pls checked ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on a diff in pull request #3474: [type:optimize] optimize netty http server parameters.
Posted by GitBox <gi...@apache.org>.
yu199195 commented on code in PR #3474:
URL: https://github.com/apache/incubator-shenyu/pull/3474#discussion_r888734888
##########
shenyu-bootstrap/src/main/resources/application.yml:
##########
@@ -71,11 +71,12 @@ management:
shenyu:
netty:
- tcp:
+ http:
Review Comment:
if modify this， you must update doc ： https://shenyu.apache.org/zh/docs/next/user-guide/property-config/gateway-property-config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] moremind commented on a diff in pull request #3474: [type:optimize] optimize netty http server parameters.
Posted by GitBox <gi...@apache.org>.
moremind commented on code in PR #3474:
URL: https://github.com/apache/incubator-shenyu/pull/3474#discussion_r888736548
##########
shenyu-bootstrap/src/main/resources/application.yml:
##########
@@ -71,11 +71,12 @@ management:
shenyu:
netty:
- tcp:
+ http:
Review Comment:
ok,I will update doc and describe the change of upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org