(superset) branch fix-eph updated (15fe5d57b8 -> 07313ad70e)

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a change to branch fix-eph
in repository https://gitbox.apache.org/repos/asf/superset.git


 discard 15fe5d57b8 make *.ipynb binary
 discard 3fd34dc8b2 fix: ephemeral environments missing env var
     new 07313ad70e fix: ephemeral environments missing env var

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (15fe5d57b8)
            \
             N -- N -- N   refs/heads/fix-eph (07313ad70e)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:

(superset) 01/01: fix: ephemeral environments missing env var

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch fix-eph
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 07313ad70e386a18c6a9ce17a99c4e849d4893c8
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Fri Nov 22 16:38:57 2024 -0800

    fix: ephemeral environments missing env var
    
    I'm not sure how my previous merge worked without the fix here, but
    fixing the issue where somehow env variables got deleted while
    copy/pasting with GPT
    
    Also adding a reply comment pointing to the logs for confirmation and
    convenience
---
 .gitattributes                      |  1 +
 .github/workflows/ephemeral-env.yml | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/.gitattributes b/.gitattributes
index 5f47e6acc8..5e7ce3d727 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -1,2 +1,3 @@
 docker/**/*.sh text eol=lf
 *.svg binary
+*.ipynb binary
diff --git a/.github/workflows/ephemeral-env.yml b/.github/workflows/ephemeral-env.yml
index 87d97a44cd..497b8145f2 100644
--- a/.github/workflows/ephemeral-env.yml
+++ b/.github/workflows/ephemeral-env.yml
@@ -78,6 +78,25 @@ jobs:
           });
           core.setFailed(errMsg);
 
+    - name: Reply with confirmation comment
+      uses: actions/github-script@v7
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        script: |
+          const issueNumber = ${{ github.event.inputs.issue_number || github.event.issue.number }};
+          const user = '${{ github.event.comment?.user.login || github.actor }}';
+          const action = '${{ steps.eval-body.outputs.result }}';
+          const body = action === 'noop'
+            ? `@${user} No ephemeral environment action detected. Please use '/testenv up' or '/testenv down'.`
+            : `@${user} Processing your ephemeral environment request: '/testenv ${action}'`;
+
+          await github.rest.issues.createComment({
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            issue_number: issueNumber,
+            body,
+          });
+
   ephemeral-docker-build:
     concurrency:
       group: ${{ github.workflow }}-${{ github.event.inputs.issue_number || github.event.issue.number || github.run_id }}-build
@@ -218,6 +237,9 @@ jobs:
     - name: Create ECS service
       id: create-service
       if: steps.describe-services.outputs.active != 'true'
+      env:
+        ECR_SUBNETS: subnet-0e15a5034b4121710,subnet-0e8efef4a72224974
+        ECR_SECURITY_GROUP: sg-092ff3a6ae0574d91
       run: |
         aws ecs create-service \
         --cluster superset-ci \