You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/19 12:29:52 UTC

[GitHub] [maven-resolver] gnodet commented on a diff in pull request #230: MRESOLVER-307 - Support listing of workspace artifacts

gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081198571


##########
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##########
@@ -55,4 +60,11 @@
      */
     List<String> findVersions( Artifact artifact );
 
+    /**
+     * List all available artifacts this workspace repository manages.
+     * 
+     * @return a stream of artifacts in no particular order
+     */
+    Stream<Artifact> listArtifacts();

Review Comment:
   Given the implementation in https://github.com/apache/maven/pull/913/files#diff-f9e3f0f97d42ff3256cbce238fa8de9cc37a14cfb961d408fc0f4d02f5dd1577R128-R133, I think it should be clearly documented that the returned stream contains the primary artifacts only, i.e. one artifact per maven module.  Attached artifacts are not returned.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org