[GitHub] [arrow] iChauster commented on a diff in pull request #13644: ARROW-17117: [C++] Add timestamp column datatype support for AsOfJoin

[GitBox <gi...@apache.org>]

iChauster commented on code in PR #13644:
URL: https://github.com/apache/arrow/pull/13644#discussion_r924763702


##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -630,24 +650,28 @@ class AsofJoinNode : public ExecNode {
       for (int i = 0; i < input_schema->num_fields(); ++i) {
         const auto field = input_schema->field(i);
         if (field->name() == on_field_name) {
-          if (kSupportedOnTypes_.find(field->type()) == kSupportedOnTypes_.end()) {
-            return Status::Invalid("Unsupported type for on key: ", field->name());
+          // Equals must be used when checking for timestamp types.
+          if (!field->type()->Equals(TimestampType(TimeUnit::NANO, "UTC")) &&

Review Comment:
   I tried this initially, but I don't think `.find(field->type())` works as intended with the timestamp fields. Per my comment, I added an additional check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org