You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/04/28 08:28:15 UTC
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a4
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18456
Change subject: WIP bump impyla dependency to 0.18a4
......................................................................
WIP bump impyla dependency to 0.18a4
Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
---
M infra/python/deps/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18456/1
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] Bump impyla dependency to 0.18.0
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18456
to look at the new patch set (#4).
Change subject: Bump impyla dependency to 0.18.0
......................................................................
Bump impyla dependency to 0.18.0
IMPALA_THRIFT_PY_VERSION is also bumped to 0.16.0p3.
As 0.16.0p3 Thrift does not contain Python related
patches and Impyla 0.18.0 depends on Thrift 0.16.0,
now we are consistantly using Thrift 0.16.0 in all
Python code.
Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
---
M bin/impala-config.sh
M infra/python/deps/requirements.txt
M shell/packaging/requirements.txt
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18456/4
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
IMPALA-11624: Bump Impyla dependency to 0.18.0
IMPALA_THRIFT_PY_VERSION is also bumped to 0.16.0p3.
As 0.16.0p3 Thrift does not contain Python related
patches and Impyla 0.18.0 depends on Thrift 0.16.0,
now we are consistently using Thrift 0.16.0 in all
Python code. This also bumps the Thrift in the
shell's ext-py directory to 0.16.0 (based on the
Thrift 0.16.0 pypi tarball with the egg directory
removed).
Testing:
- Ran a GVO job
Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Reviewed-on: http://gerrit.cloudera.org:8080/18456
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/impala-config.sh
M bin/rat_exclude_files.txt
M infra/python/deps/requirements.txt
M shell/.gitignore
D shell/ext-py/thrift-0.14.2/CMakeLists.txt
D shell/ext-py/thrift-0.14.2/Makefile.am
D shell/ext-py/thrift-0.14.2/coding_standards.md
D shell/ext-py/thrift-0.14.2/compat/win32/stdint.h
D shell/ext-py/thrift-0.14.2/setup.cfg
D shell/ext-py/thrift-0.14.2/test/_import_local_thrift.py
D shell/ext-py/thrift-0.14.2/test/test_thrift_file/TestServer.thrift
D shell/ext-py/thrift-0.14.2/test/thrift_TBinaryProtocol.py
D shell/ext-py/thrift-0.14.2/test/thrift_TCompactProtocol.py
D shell/ext-py/thrift-0.14.2/test/thrift_TNonblockingServer.py
D shell/ext-py/thrift-0.14.2/test/thrift_TZlibTransport.py
D shell/ext-py/thrift-0.14.2/test/thrift_json.py
D shell/ext-py/thrift-0.14.2/test/thrift_transport.py
R shell/ext-py/thrift-0.16.0/MANIFEST.in
R shell/ext-py/thrift-0.16.0/README.md
A shell/ext-py/thrift-0.16.0/setup.cfg
R shell/ext-py/thrift-0.16.0/setup.py
R shell/ext-py/thrift-0.16.0/src/TMultiplexedProcessor.py
R shell/ext-py/thrift-0.16.0/src/TRecursive.py
R shell/ext-py/thrift-0.16.0/src/TSCons.py
R shell/ext-py/thrift-0.16.0/src/TSerialization.py
R shell/ext-py/thrift-0.16.0/src/TTornado.py
R shell/ext-py/thrift-0.16.0/src/Thrift.py
R shell/ext-py/thrift-0.16.0/src/__init__.py
R shell/ext-py/thrift-0.16.0/src/compat.py
R shell/ext-py/thrift-0.16.0/src/ext/binary.cpp
R shell/ext-py/thrift-0.16.0/src/ext/binary.h
R shell/ext-py/thrift-0.16.0/src/ext/compact.cpp
R shell/ext-py/thrift-0.16.0/src/ext/compact.h
R shell/ext-py/thrift-0.16.0/src/ext/endian.h
R shell/ext-py/thrift-0.16.0/src/ext/module.cpp
R shell/ext-py/thrift-0.16.0/src/ext/protocol.h
R shell/ext-py/thrift-0.16.0/src/ext/protocol.tcc
R shell/ext-py/thrift-0.16.0/src/ext/types.cpp
R shell/ext-py/thrift-0.16.0/src/ext/types.h
R shell/ext-py/thrift-0.16.0/src/protocol/TBase.py
R shell/ext-py/thrift-0.16.0/src/protocol/TBinaryProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TCompactProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/THeaderProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TJSONProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TMultiplexedProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TProtocolDecorator.py
R shell/ext-py/thrift-0.16.0/src/protocol/__init__.py
R shell/ext-py/thrift-0.16.0/src/server/THttpServer.py
R shell/ext-py/thrift-0.16.0/src/server/TNonblockingServer.py
R shell/ext-py/thrift-0.16.0/src/server/TProcessPoolServer.py
R shell/ext-py/thrift-0.16.0/src/server/TServer.py
R shell/ext-py/thrift-0.16.0/src/server/__init__.py
R shell/ext-py/thrift-0.16.0/src/transport/THeaderTransport.py
R shell/ext-py/thrift-0.16.0/src/transport/THttpClient.py
R shell/ext-py/thrift-0.16.0/src/transport/TSSLSocket.py
R shell/ext-py/thrift-0.16.0/src/transport/TSocket.py
R shell/ext-py/thrift-0.16.0/src/transport/TTransport.py
R shell/ext-py/thrift-0.16.0/src/transport/TTwisted.py
R shell/ext-py/thrift-0.16.0/src/transport/TZlibTransport.py
R shell/ext-py/thrift-0.16.0/src/transport/__init__.py
R shell/ext-py/thrift-0.16.0/src/transport/sslcompat.py
R shell/ext-py/thrift-0.16.0/test/test_socket.py
R shell/ext-py/thrift-0.16.0/test/test_sslsocket.py
M shell/packaging/requirements.txt
65 files changed, 48 insertions(+), 1,375 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Wenzhe Zhou: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 19:08:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 6:
I'm going to do an upload to this that adds the ext-py changes.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 19:05:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 20:09:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18456/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18456/5//COMMIT_MSG@7
PS5, Line 7: IMPALA-11624: Bump Impyla dependency to 0.18.0
> nit: Should you add Jira number?
Created a Jira about this.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Sep 2022 09:17:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a4
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10505/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 12:00:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a6
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a6
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18456/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18456/3/bin/impala-config.sh@186
PS3, Line 186: export IMPALA_THRIFT_PY_VERSION=0.16.0-p3
In shell/packaging/requirements.txt, we set Thrift PY version as 0.16.0. Should we keep consistent?
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 03:26:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 7: Code-Review+2
Ok, I'm going to go ahead with this.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 20:39:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump impyla dependency to 0.18.0
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18456
to look at the new patch set (#5).
Change subject: Bump impyla dependency to 0.18.0
......................................................................
Bump impyla dependency to 0.18.0
IMPALA_THRIFT_PY_VERSION is also bumped to 0.16.0p3.
As 0.16.0p3 Thrift does not contain Python related
patches and Impyla 0.18.0 depends on Thrift 0.16.0,
now we are consistently using Thrift 0.16.0 in all
Python code.
Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
---
M bin/impala-config.sh
M infra/python/deps/requirements.txt
M shell/packaging/requirements.txt
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18456/5
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18456/6/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18456/6/bin/impala-config.sh@179
PS6, Line 179: shell/ext-py
Hi Csaba. Just wondering, what will happen with shell/ext-py/thrift-0.14.2 ? Do we need to replace it with source code from thrift-0.16.0 ?
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Sep 2022 10:04:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12437/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 19:26:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a4
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8065/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 08:29:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a4
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8066/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 11:40:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a6
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a6
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18456/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18456/3/bin/impala-config.sh@186
PS3, Line 186: export IMPALA_THRIFT_PY_VERSION=0.16.0-p3
> In shell/packaging/requirements.txt, we set Thrift PY version as 0.16.0. Sh
The reason for using this is that IMPALA_THRIFT_PY_VERSION is used during the .thrift->py compilation, so it referes to a cpp code generation library, not the python Thrift module itself. So we use the same library as with other languages. The same is done for Java, it uses 0.16.0-p3 compiler with vanilla 0.16.0 java library.
Note that our 0.16.0-p3 Thrift only contains c++ related patches: https://github.com/cloudera/native-toolchain/tree/ma
ster/source/thrift/thrift-0.16.0-patches
So we could use 0.16.0 instead and generate the same results, but it is more convenient to reuse the same version as in cpp.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 05:37:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Bump impyla dependency to 0.18.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: Bump impyla dependency to 0.18.0
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11469/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 17:10:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has uploaded a new patch set (#7) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
IMPALA-11624: Bump Impyla dependency to 0.18.0
IMPALA_THRIFT_PY_VERSION is also bumped to 0.16.0p3.
As 0.16.0p3 Thrift does not contain Python related
patches and Impyla 0.18.0 depends on Thrift 0.16.0,
now we are consistently using Thrift 0.16.0 in all
Python code. This also bumps the Thrift in the
shell's ext-py directory to 0.16.0 (based on the
Thrift 0.16.0 pypi tarball with the egg directory
removed).
Testing:
- Ran a GVO job
Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
---
M bin/impala-config.sh
M bin/rat_exclude_files.txt
M infra/python/deps/requirements.txt
M shell/.gitignore
D shell/ext-py/thrift-0.14.2/CMakeLists.txt
D shell/ext-py/thrift-0.14.2/Makefile.am
D shell/ext-py/thrift-0.14.2/coding_standards.md
D shell/ext-py/thrift-0.14.2/compat/win32/stdint.h
D shell/ext-py/thrift-0.14.2/setup.cfg
D shell/ext-py/thrift-0.14.2/test/_import_local_thrift.py
D shell/ext-py/thrift-0.14.2/test/test_thrift_file/TestServer.thrift
D shell/ext-py/thrift-0.14.2/test/thrift_TBinaryProtocol.py
D shell/ext-py/thrift-0.14.2/test/thrift_TCompactProtocol.py
D shell/ext-py/thrift-0.14.2/test/thrift_TNonblockingServer.py
D shell/ext-py/thrift-0.14.2/test/thrift_TZlibTransport.py
D shell/ext-py/thrift-0.14.2/test/thrift_json.py
D shell/ext-py/thrift-0.14.2/test/thrift_transport.py
R shell/ext-py/thrift-0.16.0/MANIFEST.in
R shell/ext-py/thrift-0.16.0/README.md
A shell/ext-py/thrift-0.16.0/setup.cfg
R shell/ext-py/thrift-0.16.0/setup.py
R shell/ext-py/thrift-0.16.0/src/TMultiplexedProcessor.py
R shell/ext-py/thrift-0.16.0/src/TRecursive.py
R shell/ext-py/thrift-0.16.0/src/TSCons.py
R shell/ext-py/thrift-0.16.0/src/TSerialization.py
R shell/ext-py/thrift-0.16.0/src/TTornado.py
R shell/ext-py/thrift-0.16.0/src/Thrift.py
R shell/ext-py/thrift-0.16.0/src/__init__.py
R shell/ext-py/thrift-0.16.0/src/compat.py
R shell/ext-py/thrift-0.16.0/src/ext/binary.cpp
R shell/ext-py/thrift-0.16.0/src/ext/binary.h
R shell/ext-py/thrift-0.16.0/src/ext/compact.cpp
R shell/ext-py/thrift-0.16.0/src/ext/compact.h
R shell/ext-py/thrift-0.16.0/src/ext/endian.h
R shell/ext-py/thrift-0.16.0/src/ext/module.cpp
R shell/ext-py/thrift-0.16.0/src/ext/protocol.h
R shell/ext-py/thrift-0.16.0/src/ext/protocol.tcc
R shell/ext-py/thrift-0.16.0/src/ext/types.cpp
R shell/ext-py/thrift-0.16.0/src/ext/types.h
R shell/ext-py/thrift-0.16.0/src/protocol/TBase.py
R shell/ext-py/thrift-0.16.0/src/protocol/TBinaryProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TCompactProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/THeaderProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TJSONProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TMultiplexedProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TProtocol.py
R shell/ext-py/thrift-0.16.0/src/protocol/TProtocolDecorator.py
R shell/ext-py/thrift-0.16.0/src/protocol/__init__.py
R shell/ext-py/thrift-0.16.0/src/server/THttpServer.py
R shell/ext-py/thrift-0.16.0/src/server/TNonblockingServer.py
R shell/ext-py/thrift-0.16.0/src/server/TProcessPoolServer.py
R shell/ext-py/thrift-0.16.0/src/server/TServer.py
R shell/ext-py/thrift-0.16.0/src/server/__init__.py
R shell/ext-py/thrift-0.16.0/src/transport/THeaderTransport.py
R shell/ext-py/thrift-0.16.0/src/transport/THttpClient.py
R shell/ext-py/thrift-0.16.0/src/transport/TSSLSocket.py
R shell/ext-py/thrift-0.16.0/src/transport/TSocket.py
R shell/ext-py/thrift-0.16.0/src/transport/TTransport.py
R shell/ext-py/thrift-0.16.0/src/transport/TTwisted.py
R shell/ext-py/thrift-0.16.0/src/transport/TZlibTransport.py
R shell/ext-py/thrift-0.16.0/src/transport/__init__.py
R shell/ext-py/thrift-0.16.0/src/transport/sslcompat.py
R shell/ext-py/thrift-0.16.0/test/test_socket.py
R shell/ext-py/thrift-0.16.0/test/test_sslsocket.py
M shell/packaging/requirements.txt
65 files changed, 48 insertions(+), 1,375 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18456/7
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] Bump impyla dependency to 0.18.0
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: Bump impyla dependency to 0.18.0
......................................................................
Patch Set 3:
> (1 comment)
>
> What's the additional work to keep the patch in WIP state?
Switched to the non-alpha 0.18.0 Impyla release and removed WIP state.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 16:51:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18456
to look at the new patch set (#6).
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
IMPALA-11624: Bump Impyla dependency to 0.18.0
IMPALA_THRIFT_PY_VERSION is also bumped to 0.16.0p3.
As 0.16.0p3 Thrift does not contain Python related
patches and Impyla 0.18.0 depends on Thrift 0.16.0,
now we are consistently using Thrift 0.16.0 in all
Python code.
Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
---
M bin/impala-config.sh
M infra/python/deps/requirements.txt
M shell/packaging/requirements.txt
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18456/6
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a6
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a6
......................................................................
Patch Set 3:
(1 comment)
What's the additional work to keep the patch in WIP state?
http://gerrit.cloudera.org:8080/#/c/18456/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18456/3/bin/impala-config.sh@186
PS3, Line 186: export IMPALA_THRIFT_PY_VERSION=0.16.0-p3
> The reason for using this is that IMPALA_THRIFT_PY_VERSION is used during t
Thanks for your explanation. It make sense.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 07:43:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a6
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8598/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 16:03:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9071/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 19:11:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump impyla dependency to 0.18.0
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: Bump impyla dependency to 0.18.0
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18456/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18456/5//COMMIT_MSG@7
PS5, Line 7: Bump impyla dependency to 0.18.0
nit: Should you add Jira number?
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 16:57:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18456/6/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18456/6/bin/impala-config.sh@179
PS6, Line 179: shell/ext-py
> Hi Csaba. Just wondering, what will happen with shell/ext-py/thrift-0.14.2
Oops, I need to update that to - for some reason I thought the copied eggs in ext-py were removed
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 07:25:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a6
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 21:12:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a4
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8065/
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 08:38:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a4
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a4
......................................................................
WIP bump impyla dependency to 0.18a4
Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
---
M infra/python/deps/requirements.txt
M shell/packaging/requirements.txt
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18456/2
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a6
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11412/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 16:23:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a6
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18456
to look at the new patch set (#3).
Change subject: WIP bump impyla dependency to 0.18a6
......................................................................
WIP bump impyla dependency to 0.18a6
py thrift is also upgraded to 0.16.0p3
Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
---
M bin/impala-config.sh
M infra/python/deps/requirements.txt
M shell/packaging/requirements.txt
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18456/3
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11624: Bump Impyla dependency to 0.18.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: IMPALA-11624: Bump Impyla dependency to 0.18.0
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 25 Feb 2023 00:19:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a4
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10503/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 08:35:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP bump impyla dependency to 0.18a4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a4
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8066/
--
To view, visit http://gerrit.cloudera.org:8080/18456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5
Gerrit-Change-Number: 18456
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 16:04:08 +0000
Gerrit-HasComments: No