[GitHub] drcariel commented on a change in pull request #3741: Cleaning up the test related classes

[GitBox <gi...@apache.org>]

drcariel commented on a change in pull request #3741: Cleaning up the test related classes 
URL: https://github.com/apache/incubator-openwhisk/pull/3741#discussion_r198617394
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/cli/test/WskRestBasicUsageTests.scala
 ##########
 @@ -48,14 +49,14 @@ import whisk.http.Messages
  * Tests for basic CLI usage. Some of these tests require a deployed backend.
  */
 @RunWith(classOf[JUnitRunner])
-class WskRestBasicUsageTests extends TestHelpers with WskTestHelpers {
+class WskRestBasicUsageTests extends TestHelpers with WskTestHelpers with WskActorSystem {
 
-  implicit val wskprops: common.WskProps = WskProps()
-  val wsk: common.rest.WskRest = new WskRest
+  implicit val wskprops = WskProps()
+  val wsk = new WskRestOperations
   val defaultAction: Some[String] = Some(TestUtils.getTestActionFilename("hello.js"))
   val usrAgentHeaderRegEx: String = """\bUser-Agent\b": \[\s+"OpenWhisk\-CLI/1.\d+.*"""
 
-  behavior of "Wsk CLI usage"
+  behavior of "Wsk API basic usage"
 
 Review comment:
   👍 good catch - `val usrAgentHeaderRegEx: String = """\bUser-Agent\b": \[\s+"OpenWhisk\-CLI/1.\d+.*"""` is also unnecessary here - something else I missed to clean up when separating the tests tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services