You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/09 17:03:07 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #11981: feat(charts): security perm simplification
codecov-io commented on pull request #11981:
URL: https://github.com/apache/incubator-superset/pull/11981#issuecomment-741908335
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11981?src=pr&el=h1) Report
> Merging [#11981](https://codecov.io/gh/apache/incubator-superset/pull/11981?src=pr&el=desc) (295a16d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cc44a2c01b31e0f51eb8bdfe70d7989b245228e4?el=desc) (cc44a2c) will **decrease** coverage by `2.85%`.
> The diff coverage is `18.91%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11981?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11981 +/- ##
==========================================
- Coverage 66.26% 63.40% -2.86%
==========================================
Files 941 466 -475
Lines 45715 28625 -17090
Branches 4395 0 -4395
==========================================
- Hits 30293 18150 -12143
+ Misses 15287 10475 -4812
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.40% <18.91%> (-0.86%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11981?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [.../versions/ccb74baaa89b\_security\_converge\_charts.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jY2I3NGJhYWE4OWJfc2VjdXJpdHlfY29udmVyZ2VfY2hhcnRzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/views/chart/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvdmlld3MucHk=) | `88.09% <100.00%> (+0.59%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.98% <100.00%> (-3.73%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| ... and [500 more](https://codecov.io/gh/apache/incubator-superset/pull/11981/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11981?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11981?src=pr&el=footer). Last update [cc44a2c...295a16d](https://codecov.io/gh/apache/incubator-superset/pull/11981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org