You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/09/29 23:59:00 UTC
[jira] [Commented] (PARQUET-2355) Remove parquet-thrift
[ https://issues.apache.org/jira/browse/PARQUET-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770620#comment-17770620 ]
ASF GitHub Bot commented on PARQUET-2355:
-----------------------------------------
mystic-lama commented on PR #1158:
URL: https://github.com/apache/parquet-mr/pull/1158#issuecomment-1741591460
Do we want to make it deprecated now and remove in a major release?
> Remove parquet-thrift
> ---------------------
>
> Key: PARQUET-2355
> URL: https://issues.apache.org/jira/browse/PARQUET-2355
> Project: Parquet
> Issue Type: Improvement
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
>
> I was in the process of updating to [the latest version of Thrift|https://github.com/apache/parquet-mr/pull/1138] (from 0.16.0 to 0.19.0). Mostly because it contains CVEs and makes the release process easier because you don't have to install Thrift from source (it is just available on homebrew etc).
>
> While working on this, I ran into an issue with Elephantbird, which is using a very old version of Thrift (0.7.0). Trying to bump this I noticed that a lot of classes that we use in the tests [have|https://github.com/apache/parquet-mr/pull/1156] [ been made private|https://github.com/apache/parquet-mr/pull/1156]. Therefore it is hard to test if we break anything.
>
> It looks like parquet-thrift [is not used by anyone anymore|https://mvnrepository.com/artifact/org.apache.parquet/parquet-thrift]. I would suggest removing this from the repository unless anyone objects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)