You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com> on 2015/09/23 21:50:40 UTC
Review Request 38687: SAMZA-563: Make Samza's minimum supported YARN
to 2.6
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38687/
-----------------------------------------------------------
Review request for samza, Aleksandar Pejakovic, Yan Fang, and Navina Ramesh.
Repository: samza
Description
-------
SAMZA-563: Remove Yarn 2.4 and 2.5 in bin/check-all.sh; add Yarn 2.7.1 to bin/check-all.sh
Diffs
-----
README.md c736669be5d2e3e608d4a036b7ff1e1b1d77973d
bin/check-all.sh 67bf7760f00bbf7f6ea1f54b9336835bb1a5a185
docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 7a9fdf493fd5281da506e853c44420aa4a00f9cc
gradle/dependency-versions.gradle 36d564b6ca895f042ee4802643e49180f4947b62
samza-test/src/main/python/configs/downloads.json a75756f9ba271beb6fcd3a7fe3aea90088479b3a
samza-test/src/main/python/configs/yarn.json 9b0143de9a801bce771221015e6d68e7495e6727
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala df5992e659302d2918c4e2c30b6122ed51ab9fe8
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala 2eec65f02826de40493925c08ff344a8cc4feecb
Diff: https://reviews.apache.org/r/38687/diff/
Testing
-------
Tests done:
1) ./bin/check-all.sh passed
2) ./gradlew publishToMavenLocal and build/run hello-samza with change in https://reviews.apache.org/r/36728/ passed
3) ./gradlew -PyarnVersion=2.7.1 publishToMavenLocal and build/run hello-samza with change in https://reviews.apache.org/r/36728/ passed
Thanks,
Yi Pan (Data Infrastructure)
Re: Review Request 38687: SAMZA-563: Make Samza's minimum supported
YARN to 2.6
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
> On Sept. 24, 2015, 5:40 a.m., Navina Ramesh wrote:
> > lgtm! Quick question: Isn't change same as https://reviews.apache.org/r/36727 ?
Thanks! The difference between this one and 36727 is that this one removed 2.4, 2.5 and added 2.7.1 to check-all.sh
- Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38687/#review100367
-----------------------------------------------------------
On Sept. 23, 2015, 7:50 p.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38687/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 7:50 p.m.)
>
>
> Review request for samza, Aleksandar Pejakovic, Yan Fang, and Navina Ramesh.
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-563: Remove Yarn 2.4 and 2.5 in bin/check-all.sh; add Yarn 2.7.1 to bin/check-all.sh
>
>
> Diffs
> -----
>
> README.md c736669be5d2e3e608d4a036b7ff1e1b1d77973d
> bin/check-all.sh 67bf7760f00bbf7f6ea1f54b9336835bb1a5a185
> docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 7a9fdf493fd5281da506e853c44420aa4a00f9cc
> gradle/dependency-versions.gradle 36d564b6ca895f042ee4802643e49180f4947b62
> samza-test/src/main/python/configs/downloads.json a75756f9ba271beb6fcd3a7fe3aea90088479b3a
> samza-test/src/main/python/configs/yarn.json 9b0143de9a801bce771221015e6d68e7495e6727
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala df5992e659302d2918c4e2c30b6122ed51ab9fe8
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala 2eec65f02826de40493925c08ff344a8cc4feecb
>
> Diff: https://reviews.apache.org/r/38687/diff/
>
>
> Testing
> -------
>
> Tests done:
> 1) ./bin/check-all.sh passed
> 2) ./gradlew publishToMavenLocal and build/run hello-samza with change in https://reviews.apache.org/r/36728/ passed
> 3) ./gradlew -PyarnVersion=2.7.1 publishToMavenLocal and build/run hello-samza with change in https://reviews.apache.org/r/36728/ passed
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
Re: Review Request 38687: SAMZA-563: Make Samza's minimum supported
YARN to 2.6
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38687/#review100367
-----------------------------------------------------------
Ship it!
lgtm! Quick question: Isn't change same as https://reviews.apache.org/r/36727 ?
- Navina Ramesh
On Sept. 23, 2015, 7:50 p.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38687/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 7:50 p.m.)
>
>
> Review request for samza, Aleksandar Pejakovic, Yan Fang, and Navina Ramesh.
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-563: Remove Yarn 2.4 and 2.5 in bin/check-all.sh; add Yarn 2.7.1 to bin/check-all.sh
>
>
> Diffs
> -----
>
> README.md c736669be5d2e3e608d4a036b7ff1e1b1d77973d
> bin/check-all.sh 67bf7760f00bbf7f6ea1f54b9336835bb1a5a185
> docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 7a9fdf493fd5281da506e853c44420aa4a00f9cc
> gradle/dependency-versions.gradle 36d564b6ca895f042ee4802643e49180f4947b62
> samza-test/src/main/python/configs/downloads.json a75756f9ba271beb6fcd3a7fe3aea90088479b3a
> samza-test/src/main/python/configs/yarn.json 9b0143de9a801bce771221015e6d68e7495e6727
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala df5992e659302d2918c4e2c30b6122ed51ab9fe8
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala 2eec65f02826de40493925c08ff344a8cc4feecb
>
> Diff: https://reviews.apache.org/r/38687/diff/
>
>
> Testing
> -------
>
> Tests done:
> 1) ./bin/check-all.sh passed
> 2) ./gradlew publishToMavenLocal and build/run hello-samza with change in https://reviews.apache.org/r/36728/ passed
> 3) ./gradlew -PyarnVersion=2.7.1 publishToMavenLocal and build/run hello-samza with change in https://reviews.apache.org/r/36728/ passed
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>