[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1124: Fix cppcoreguidelines-special-member-functions warning reported by cl…

[GitBox <gi...@apache.org>]

PragmaTwice commented on code in PR #1124:
URL: https://github.com/apache/incubator-kvrocks/pull/1124#discussion_r1022550712


##########
src/commands/redis_cmd.cc:
##########
@@ -1661,6 +1661,15 @@ class CommandRPop : public CommandPop {
 class CommandBPop : public Commander {
  public:
   explicit CommandBPop(bool left) : left_(left) {}
+
+  CommandBPop() = default;
+
+  // Not copyable
+  CommandBPop(const CommandBPop &) = delete;
+  CommandBPop(CommandBPop &&) = delete;
+  CommandBPop &operator=(const CommandBPop &) = delete;
+  CommandBPop &operator=(CommandBPop &&) = delete;

Review Comment:
   ```suggestion
     CommandBPop(const CommandBPop &) = delete;
     CommandBPop &operator=(const CommandBPop &) = delete;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org